Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TS): Error impls now properly type `this` #4978

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@benlesh
Copy link
Member

commented Aug 22, 2019

Fixes an issue with TypeScript compilation in more strict environments.

Fixes an issue with TypeScript compilation in more strict environments.
@kwonoj
kwonoj approved these changes Aug 22, 2019
Copy link
Collaborator

left a comment

LGTM

@benlesh benlesh merged commit 7606dc7 into ReactiveX:master Aug 26, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: dtslint Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: typescript3 Your tests passed on CircleCI!
Details
@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.