Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(skip): add description and example for the operator #5773

Merged
merged 2 commits into from Sep 30, 2020
Merged

docs(skip): add description and example for the operator #5773

merged 2 commits into from Sep 30, 2020

Conversation

hardikpthv
Copy link
Contributor

Description:

  • Add description, example, and See Also section for the skip operator

Related issue (if exists):

niklas-wortmann
niklas-wortmann requested changes Sep 29, 2020
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi one minor thing again :D Many thanks for you contributions I really appreciate it

src/internal/operators/skip.ts Outdated Show resolved Hide resolved
@hardikpthv
Copy link
Contributor Author

Hi one minor thing again :D Many thanks for you contributions I really appreciate it

You're welcome, @niklas-wortmann! Happy to contribute :)

niklas-wortmann
niklas-wortmann approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niklas-wortmann niklas-wortmann merged commit e4e59db into ReactiveX:master Sep 30, 2020
@hardikpthv hardikpthv deleted the docs/improve-skip-operator-content branch September 30, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklas-wortmann niklas-wortmann niklas-wortmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs]: Suggestions for skip documentation improvements
2 participants
@hardikpthv @niklas-wortmann