feat: add config object to connectable#6267
Merged
benlesh merged 3 commits intoReactiveX:masterfrom Apr 27, 2021
Merged
Conversation
benlesh
reviewed
Apr 27, 2021
benlesh
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the API of the new-to-version-7
connectablefunction. The changes introduce a config object (much like the one used in theconnectandshareoperators) that:connectorsubject factory to be passed;resetOnDisconnectoption to be specified.Without these changes, it wasn't possible to refactor all use cases of
ConnectableObservableto useconnectablebecauseConnectableObservablewould reset its subject upon disconnection - that is, on callingunsubscribeon theSubscriptionreturned from theconnectmethod.This PR adds a few tests (there were none) for
connectable.Related issue (if exists): Nope