Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ajax): crossDomain flag deprecated and properly reported to consumers #6710

Merged
merged 3 commits into from Jan 11, 2022

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Dec 6, 2021

Fixes an issue where the crosDomain flag was being incorrectly reported to users via error objects and response objects as defaulting to true, when it was in fact defaulting to false.

Deprecates the crossDomain flag in favor of allowing the configuration of the request and the browser to dictate whether or not a preflight request is necessary. Adds deprecation messages with advice about how to force CORS preflights. Ultimately, the boolean flag does not make sense, as there are a lot of factors that dictate CORS preflight use and they may vary by browser/environment.

Resolves #6663

@benlesh benlesh mentioned this pull request Dec 6, 2021
benlesh added 3 commits Jan 4, 2022
…mers

Fixes an issue where the `crosDomain` flag was being incorrectly reported to users via error objects and response objects as defaulting to `true`, when it was in fact defaulting to `false`.

Deprecates the `crossDomain` flag in favor of allowing the configuration of the request and the browser to dictate whether or not a preflight request is necessary. Adds deprecation messages with advice about how to force CORS preflights. Ultimately, the boolean flag does not make sense, as there are a lot of factors that dictate CORS preflight use and they may vary by browser/environment.

Resolves ReactiveX#6663
@benlesh benlesh requested a review from kwonoj Jan 7, 2022
kwonoj
kwonoj approved these changes Jan 8, 2022
@benlesh benlesh added 7.x 8.x labels Jan 11, 2022
@benlesh benlesh merged commit 7fd0575 into ReactiveX:master Jan 11, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants