Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Never instead of NoAction / NoMutation #100

Merged

Conversation

Projects
None yet
3 participants
@kemchenj
Copy link
Contributor

commented Apr 13, 2019

Since Never could not be instantiated, so I think using it will be better than NoAction and NoMutation.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 13, 2019

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files           7        7           
  Lines         113      113           
=======================================
  Hits          104      104           
  Misses          9        9
Impacted Files Coverage Δ
Sources/ReactorKit/Reactor.swift 82.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d67b8d...e4ded97. Read the comment docs.

@devxoul devxoul merged commit 7db8d30 into ReactorKit:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devxoul

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.