Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parsing error for Carthage example. #105

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@wanbok
Copy link
Contributor

commented May 24, 2019

Cathage seems to allow only " not ' as a quote in the syntax.
And also, Carthage made by swift, that's why to change the syntax highlight for Carthage example.

https://github.com/Carthage/Carthage/blob/master/Source/CarthageKit/Cartfile.swift#L190

Fix the parsing error for Carthage example.
Cathage seems to allow only `"` not `'` as a quote in the syntax.
And also, Carthage made by swift, that's why to change the syntax highlight for Carthage example.

https://github.com/Carthage/Carthage/blob/master/Source/CarthageKit/Cartfile.swift#L190
@codecov-io

This comment has been minimized.

Copy link

commented May 24, 2019

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files           7        7           
  Lines         113      113           
=======================================
  Hits          104      104           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db8d30...1daf05e. Read the comment docs.

@devxoul

devxoul approved these changes Jun 6, 2019

@devxoul devxoul merged commit 4b78322 into ReactorKit:master Jun 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devxoul

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Thanks for your contribution @wanbok 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.