Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's Swift 5.0 馃殌 #106

Merged
merged 7 commits into from Jun 15, 2019

Conversation

Projects
None yet
4 participants
@devxoul
Copy link
Member

commented Jun 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #106 into master will increase coverage by 2.11%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   92.03%   94.15%   +2.11%     
==========================================
  Files           7        7              
  Lines         113      171      +58     
==========================================
+ Hits          104      161      +57     
- Misses          9       10       +1
Impacted Files Coverage 螖
Sources/ReactorKit/StateRelay.swift 84.61% <0%> (酶) 猬嗭笍
Sources/ReactorKit/ActionSubject.swift 100% <100%> (酶) 猬嗭笍
Sources/ReactorKit/StoryboardView.swift 100% <0%> (酶) 猬嗭笍
Sources/ReactorKit/AssociatedObjectStore.swift 100% <0%> (酶) 猬嗭笍
Sources/ReactorKit/Reactor.swift 91.01% <0%> (+8.51%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4b78322...900bf02. Read the comment docs.

@mariohahn

This comment has been minimized.

Copy link

commented Jun 14, 2019

馃帀

@devxoul devxoul force-pushed the swift-5.0 branch from ab37fdb to 900bf02 Jun 15, 2019

@devxoul devxoul merged commit c1db412 into master Jun 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@PierreBrisorgueil

This comment has been minimized.

Copy link

commented Jun 15, 2019

Thx a lot ! 馃憤

@devxoul devxoul deleted the swift-5.0 branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.