Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that mutate and reduce are executed in the same serial scheduler #131

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@devxoul
Copy link
Member

devxoul commented Oct 24, 2019

If the mutate() and reduce() are performed in the difference scheduler, it will break the proper order of executions.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #131 into master will increase coverage by 0.93%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   94.76%   95.69%   +0.93%     
==========================================
  Files           9        9              
  Lines         210      209       -1     
==========================================
+ Hits          199      200       +1     
+ Misses         11        9       -2
Impacted Files Coverage Δ
Sources/ReactorKit/Reactor.swift 93.75% <100%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c49334...dc8f2fe. Read the comment docs.

@devxoul devxoul merged commit f95a197 into master Oct 24, 2019
3 checks passed
3 checks passed
test (iphonesimulator13.0, platform=iOS Simulator,name=iPhone 11 Pro,OS=13.0)
Details
test (macosx10.15, arch=x86_64)
Details
test (appletvsimulator13.0, OS=13.0,name=Apple TV)
Details
@devxoul devxoul deleted the scheduler-mutate-reduce branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.