fix : 409 status code when add_bookmark now returns a boorkmark object #1

Merged
merged 2 commits into from Jan 25, 2012

Projects

None yet

2 participants

oleiade commented Jan 24, 2012

I noticed that whether the documentation said that when a 409 status "should also provide a Location header to the resource in question", it was not the case when applying add_bookmark on an already processed url.

add_bookmark was raising an Error whenever the request status was not 200 or 202, instead of returning
the existing bookmark of corresponding to the requested Url; or at least it's location header.

Fixed it by adding the '409' status to the accepted add_bookmark requests status.
Now returns the already existing bookmark.

Theo crevon fix : 409 status code when add_bookmark now returns a boorkmark object
I noticed that whether the documentation said that when a 409 status "should also provide a Location header to the resource in question", it was not the case when applying add_bookmark on an already processed url.
add_bookmark was raising an Error whenever the request status was not 200 or 202, instead of returning
the existing bookmark of corresponding to the requested Url; or at least it's location header.
Fixed it by adding the '409' status to the accepted add_bookmark requests status. Now returns
the already existing bookmark.
1786175
Contributor
umbrae commented Jan 24, 2012

Looks clear Theo, one request - can you use spaces instead of tabs for your indentation?

oleiade commented Jan 24, 2012

Fixed the indentations, I guess my emacs betrayed me ! :-)

@umbrae umbrae merged commit 6870608 into ReadabilityHoldings:develop Jan 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment