Format 418 responses per the RFC #2

Merged
merged 1 commit into from Jan 23, 2014

3 participants

@EugeneKay

RFC 2324 specifies that the 418 error code conforms to "I'm a teapot",
with a lowercase letter T. This commit corrects the deficiency in the
current implementation, which featured an uppercase T.

Signed-off-by: Eugene E. Kashpureff Jr eugene@khresear.ch

@EugeneKay EugeneKay Format 418 responses per the RFC
RFC 2324 specifies that the 418 error code conforms to "I'm a teapot",
with a lowercase letter T. This commit corrects the deficiency in the
current implementation, which featured an uppercase T.

Signed-off-by: Eugene E. Kashpureff Jr <eugene@khresear.ch>
7e5d3bb
@EugeneKay

While this change may appear superficial, it is critical that edge case errors are handled appropriately by unit tests. Violating the RFC with improperly cased responses may cause issues with case-sensitive regular expressions that verify these responses. Changing the deployed behavior may introduce problems with existing scripts which depend upon the uppercase T. However, this will draw attention to the faulty unit test and result in downstream code corrections to handle such edge cases.

@dth

Outstanding!

@tathamoddie tathamoddie merged commit ea94060 into Readify:master Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment