Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Break out compiler.cpp into sub-components #38

Merged
merged 24 commits into from Feb 15, 2013

Conversation

Projects
None yet
2 participants
Contributor

joshuawarner32 commented Feb 14, 2013

I moved most of compiler.cpp into separate files in src/codegen/compiler/*. This should decrease the cognitive load of puzzling out what "compiler" does. In the future, it will make it significantly easier to write unit tests for parts of the compiler. It also opens up the possibility of making incremental rebuilds in compiler significantly faster.

I also merged all of the various definitions of abort, assert, and expect - using the magic of templates.

Joshua Warner and others added some commits Feb 12, 2013

Member

dicej commented Feb 14, 2013

Thanks for working on this. Has it been tested on x86, ARM, and PowerPC?

Contributor

joshuawarner32 commented Feb 14, 2013

It has not; however, I tried very hard not to make any functional changes. I was only reorganizing code. Just in case, I'll go ahead and run 'make test' on all of those platforms.

Contributor

joshuawarner32 commented Feb 14, 2013

All tests pass on x86_64, x86, and ARM (all linux), as well as x86_64 (darwin).
They would probably all pass on PowerPC (linux), but running on a qemu vm, the OutOfMemory test timed out my ssh connection.

@dicej dicej merged commit b4a73a2 into ReadyTalk:master Feb 15, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment