Fix bootimage build #40

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@joshuawarner32
Contributor

joshuawarner32 commented Feb 17, 2013

The bootimage build (specifically, bootimage.cpp) was broken in the wake of the recent codegen namespace reorganization. This fixes the errors.

@dicej

This comment has been minimized.

Show comment
Hide comment
@dicej

dicej Feb 19, 2013

Member

Travis claims the bootimage build is working just fine: https://travis-ci.org/ReadyTalk/avian

What platform(s) are you having trouble on?

Member

dicej commented Feb 19, 2013

Travis claims the bootimage build is working just fine: https://travis-ci.org/ReadyTalk/avian

What platform(s) are you having trouble on?

@dicej

This comment has been minimized.

Show comment
Hide comment
Member

dicej commented Feb 19, 2013

@joshuawarner32

This comment has been minimized.

Show comment
Hide comment
@joshuawarner32

joshuawarner32 Feb 19, 2013

Contributor

I was building on darwin-x86_64; given the changes in the patch, I don't know how it's building unless those same changes already made their way into the repo. I'll investigate.

Contributor

joshuawarner32 commented Feb 19, 2013

I was building on darwin-x86_64; given the changes in the patch, I don't know how it's building unless those same changes already made their way into the repo. I'll investigate.

@dicej

This comment has been minimized.

Show comment
Hide comment
@dicej

dicej Feb 19, 2013

Member

On Tue, 19 Feb 2013, Joshua Warner wrote:

I was building on darwin-x86_64; given the changes in the patch, I don't
know how it's building unless those same changes already made their way into
the repo. I'll investigate.

Did you have
fbbd718
when you built?

Member

dicej commented Feb 19, 2013

On Tue, 19 Feb 2013, Joshua Warner wrote:

I was building on darwin-x86_64; given the changes in the patch, I don't
know how it's building unless those same changes already made their way into
the repo. I'll investigate.

Did you have
fbbd718
when you built?

@joshuawarner32

This comment has been minimized.

Show comment
Hide comment
@joshuawarner32

joshuawarner32 Feb 19, 2013

Contributor

Oops... You're right. I should have pulled to make sure you didn't already fix it. :-)

Contributor

joshuawarner32 commented Feb 19, 2013

Oops... You're right. I should have pulled to make sure you didn't already fix it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment