Output html5 tags instead of incorrect xhtml #11

Closed
tahajahangir opened this Issue Jan 10, 2014 · 2 comments

Projects

None yet

2 participants

@tahajahangir

Current html output of realfavicongenerator is as follows:

<link rel="shortcut icon" href=".../favicon.ico">
<link rel="apple-touch-icon" sizes="57x57" href=".../apple-touch-icon-57x57.png" />
<link rel="apple-touch-icon" sizes="114x114" href=".../apple-touch-icon-114x114.png" />

The first tag is not self-closing, but others are.
There is better not to use self-closing tags at all, browsers are parsing response as xhtml, only if it's Content-Type be application/xhtml+xml (which is very rare). If the content type be text/html, the document shoud be HTML not XHTML.

see: http://www.w3.org/TR/xhtml-media-types/#application-xhtml-xml

@phbernard
Contributor

You're right, this is a bit messy and not accurate. Thank you for reporting!

The update is easy, testing will require more time. I will address this next week.

@phbernard phbernard was assigned Jan 10, 2014
@phbernard
Contributor
@phbernard phbernard closed this Jan 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment