New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output html5 tags instead of incorrect xhtml #11

Closed
tahajahangir opened this Issue Jan 10, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@tahajahangir

tahajahangir commented Jan 10, 2014

Current html output of realfavicongenerator is as follows:

<link rel="shortcut icon" href=".../favicon.ico">
<link rel="apple-touch-icon" sizes="57x57" href=".../apple-touch-icon-57x57.png" />
<link rel="apple-touch-icon" sizes="114x114" href=".../apple-touch-icon-114x114.png" />

The first tag is not self-closing, but others are.
There is better not to use self-closing tags at all, browsers are parsing response as xhtml, only if it's Content-Type be application/xhtml+xml (which is very rare). If the content type be text/html, the document shoud be HTML not XHTML.

see: http://www.w3.org/TR/xhtml-media-types/#application-xhtml-xml

@phbernard

This comment has been minimized.

Contributor

phbernard commented Jan 10, 2014

You're right, this is a bit messy and not accurate. Thank you for reporting!

The update is easy, testing will require more time. I will address this next week.

@ghost ghost assigned phbernard Jan 10, 2014

@phbernard

This comment has been minimized.

Contributor

phbernard commented Jan 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment