Skip to content

/ realfavicongenerator

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Density as number in Web / Android Chrome manifest #141

Closed
phbernard opened this issue Feb 18, 2015 · 3 comments
Closed

Density as number in Web / Android Chrome manifest #141

phbernard opened this issue Feb 18, 2015 · 3 comments
Labels
enhancement
Milestone
Package v0.12

Comments

@phbernard
Copy link
Contributor

@phbernard phbernard commented Feb 18, 2015

Currently, the manifest for Android Chrome has density field values as string (eg. "0.75"). However, they should be numbers (eg. 0.75), see http://www.w3.org/2008/webapps/manifest/

Two steps to implement this:

  • Make sure Android Chrome accepts this kind of value. This is because Google's specs conflict with W3C's.
  • Actually change the manifest encoding.
@phbernard
Copy link
Contributor Author

@phbernard phbernard commented May 28, 2015

Apparently, Chrome explicitly rejects the quotes (observed in the dev console). So first step "make sure it's the right thing to do" is validated.
phbernard added a commit to RealFaviconGenerator/realfavicongenerator-api-test-suite that referenced this issue May 28, 2015
@phbernard
In Android manifest file, density is now a genuine number (no more qu…
7e5b8a6 
…otes), see RealFaviconGenerator/realfavicongenerator#141
@phbernard
Copy link
Contributor Author

@phbernard phbernard commented May 28, 2015

Done. It will be part of v0.11 (see http://realfavicongenerator.net/change_log).
@phbernard phbernard added this to the Package v0.11 milestone Sep 7, 2015
@phbernard
Copy link
Contributor Author

@phbernard phbernard commented Feb 18, 2016

That was released on 2015/12/03 as part of v0.12, see http://realfavicongenerator.net/change_log
@phbernard phbernard closed this Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Package v0.12
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@phbernard
You can’t perform that action at this time.