Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for "retina" favicon in Firefox Mac #17
Thank you! :)
I suppose you have a Retina Mac, right? Could you first run the compatibility test with Firefox in order to spot the current RFG'code behavior with this platform and browser?
As far as I understand, FF for Retina Mac is using the 32x32 PNG picture, or else the 16x16 PNG picture. However this contradicts issue 751712. Do you have reference information about this topic?
I received the results of your first test. Ok, the 16x16 PNG picture is used, and it is blurry. Unfortunately, this result is not a surprise.
I would be glad if you could try the workaround you suggest: if you move the 32x32 declaration to the last position, what happens? Is the 32x32 icon used instead? (ie. not blurry anymore)
If the test is conclusive, I will update the generated code.
Ouch. That's right. The 16x16 and 32x32 PNG icons are inverted in the current version. Clearly a bug. It was introduced during the refactoring that took place in 2014Q4 when writing the non-interactive API. Thank you for reporting!
The fix itself it simple and I updated the compatibility tests to reflect the change, so this new version can be tested right now.
However I will have a very limited bandwidth this week so I won't be able to re-run the tests and deploy the fix.