Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Density descriptors in manifest.json should not be included #228
Hi, I edit the W3C Manifest specification and work on Firefox's implementation of W3C manifest. Firstly, thanks for adding W3C manifest support via this plugin!
I would like to point out a small, but significant, issue that's currently affecting users. The usage of the "density" member in your generated manifest is currently being used incorrectly and should be removed.
The purpose of "density" is to say: "only ever use this icon when the density of the screen is at least X" (see spec). Right now, almost none of the icons will match, because there are no screen that, for instance, have a density "4.0" and very few that have "3.0".
I would kindly ask that you please remove the density member from the generated manifest.
Please let me know if you have any questions and if I can help fix this! I tried to track down the generator for this, but I had trouble finding it.
Ok, but that's not the point: a 192x192px icon is fine to use at 1x (even if designed for 4x). You don't want to discriminate on density unless you absolutely need to. It might make more sense for us to drop density from the spec and implementations if people using it incorrectly. Discriminating on density is a bit of a corner case, specifically nowadays where 2x is the norm and 3x is also becoming normal.
Sent from my iPhone
Thank you @marcoscaceres for your feedback. I'm glad the manifest is spreading and I hope RFG is a significant contributor :)
Okay, I understand. I'm going to remove the