New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate the 96x96 PNG icon for Google TV anymore #230

Closed
phbernard opened this Issue Apr 14, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@phbernard
Contributor

phbernard commented Apr 14, 2016

Definitely not sure the 96x96 PNG icon is important. It's only for Google TV, which was replaced by Android TV with no evidence that the 96x96 PNG icon is still useful.

Plus this icon is wrongly loaded by Firefox.

Supporting a confidential platform at the cost of hampering a mainstream one doesn't worth it. Better not support it at all.

@phbernard phbernard added this to the Package v0.13 milestone Apr 14, 2016

@phbernard

This comment has been minimized.

Show comment
Hide comment
@phbernard

phbernard May 17, 2016

Contributor

Implemented in branch package_0_13

Contributor

phbernard commented May 17, 2016

Implemented in branch package_0_13

@phbernard

This comment has been minimized.

Show comment
Hide comment
@phbernard

phbernard Jul 1, 2016

Contributor

Deployed yesterday

Contributor

phbernard commented Jul 1, 2016

Deployed yesterday

@bartvanandel

This comment has been minimized.

Show comment
Hide comment
@bartvanandel

bartvanandel Aug 18, 2016

Is it correct behavior that #143 introduced using 'android-chrome-192x192.png' for the 192x192 favicon and removes the 230x230 resolution? Judging by the filename this seems inappropriate or at least counterintuitive. I did not test this, but I guess this file is only generated when the right options are set, so this will cause invalid results when using {android: false, favicons: true}.

With the current version, the 230x230 file is no longer referenced anywhere in html or manifest files, but it's still being generated. If the file is not needed, it should probably not be generated.

bartvanandel commented Aug 18, 2016

Is it correct behavior that #143 introduced using 'android-chrome-192x192.png' for the 192x192 favicon and removes the 230x230 resolution? Judging by the filename this seems inappropriate or at least counterintuitive. I did not test this, but I guess this file is only generated when the right options are set, so this will cause invalid results when using {android: false, favicons: true}.

With the current version, the 230x230 file is no longer referenced anywhere in html or manifest files, but it's still being generated. If the file is not needed, it should probably not be generated.

@phbernard

This comment has been minimized.

Show comment
Hide comment
@phbernard

phbernard Sep 2, 2016

Contributor

The sample configuration you give is for https://github.com/haydenbleasel/favicons , is that right? Is it really related to this issue?

Contributor

phbernard commented Sep 2, 2016

The sample configuration you give is for https://github.com/haydenbleasel/favicons , is that right? Is it really related to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment