Don't generate the 96x96 PNG icon for Google TV anymore #230

Closed
phbernard opened this Issue Apr 14, 2016 · 4 comments

Projects

None yet

2 participants

@phbernard
Contributor

Definitely not sure the 96x96 PNG icon is important. It's only for Google TV, which was replaced by Android TV with no evidence that the 96x96 PNG icon is still useful.

Plus this icon is wrongly loaded by Firefox.

Supporting a confidential platform at the cost of hampering a mainstream one doesn't worth it. Better not support it at all.

@phbernard phbernard added this to the Package v0.13 milestone Apr 14, 2016
@phbernard
Contributor

Implemented in branch package_0_13

@phbernard
Contributor

Deployed yesterday

@phbernard phbernard closed this Jul 1, 2016
@bartvanandel

Is it correct behavior that #143 introduced using 'android-chrome-192x192.png' for the 192x192 favicon and removes the 230x230 resolution? Judging by the filename this seems inappropriate or at least counterintuitive. I did not test this, but I guess this file is only generated when the right options are set, so this will cause invalid results when using {android: false, favicons: true}.

With the current version, the 230x230 file is no longer referenced anywhere in html or manifest files, but it's still being generated. If the file is not needed, it should probably not be generated.

@greenkeeperio-bot greenkeeperio-bot referenced this issue in davewasmer/broccoli-favicon Aug 20, 2016
Open

favicons@4.7.8 breaks build 🚨 #22

@phbernard
Contributor

The sample configuration you give is for https://github.com/haydenbleasel/favicons , is that right? Is it really related to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment