Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the msapplication-TileImage tile icon for Windows 8.0 / IE 10 optional #231

Closed
phbernard opened this issue Apr 19, 2016 · 7 comments
Closed
Labels
Milestone

Comments

@phbernard
Copy link
Contributor

@phbernard phbernard commented Apr 19, 2016

Windows 8.1 / IE 11 and Windows 10 / (IE 11 / Edge) rely on the browserconfig.xml file and a set of icons. But Windows 8.0 / IE 10 doesn't support it and expects the meta msapplication-TileImage, which should be a 144x144 image. Is it really useful now that Windows 8.0 accounts for a little less than 2.5% market share? (versus 24% for Win 8.1 & 10 combined)

The idea here is to make this icon optional. In other words, disabled by default, with an option to generate it again.

Of course, if we decide to go this route, we will first perform compatibility tests to check the outcome.

Note: last time I checked, Coast by Opera was using this icon when it couldn't find a dedicated PNG image.

@phbernard
Copy link
Contributor Author

@phbernard phbernard commented Apr 20, 2016

Why doing this?

  • To save two markups. Not a big deal, but not a huge market share either. This is in line with the upcoming update, in particular #211.
  • For clarity. Currently the msapplication-TileImage looks like it conflicts with browserconfig.xml (although that's not the case).
@phbernard phbernard added this to the Package v0.13 milestone Apr 20, 2016
@ghost
Copy link

@ghost ghost commented May 1, 2016

Hi,
I just created my favicons, I paste the code given by the site, just, I'd rather put a folder of favicon, so I modify each line, then I do the test and I have this error message, why
Some Windows 8 / IE11 tile(s) could not be found or are corrupted.
thank you

@phbernard
Copy link
Contributor Author

@phbernard phbernard commented May 3, 2016

Is you site live? Could you give me its URL?

@phbernard
Copy link
Contributor Author

@phbernard phbernard commented May 19, 2016

Implemented in branch package_0_13

@ghost
Copy link

@ghost ghost commented May 28, 2016

Hi,
http://irondove.fr
my site
thank you

@phbernard
Copy link
Contributor Author

@phbernard phbernard commented Jun 3, 2016

When you created your icon with RealFaviconGenerator, you probably indicated you would place your icons in the root directory of your web site. Then, you changed your mind and edited the HTML code to indicate /favicons as a sub directory. Am I right?

The problem with this is that browserconfig.xml doesn't have to be declared... when it is in the root directory. But it needs to in the other cases.

My advice is to create your favicon again, and this time indicate the definitive location of your files. This is way safer than editing the generated code and files manually.

@phbernard
Copy link
Contributor Author

@phbernard phbernard commented Jul 1, 2016

Deployed yesterday

@phbernard phbernard closed this Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.