-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari mask icon resolution / viewBox #242
Comments
Same here. SVG icon does not display well. |
Really? Although the viewBox is not correct, all my experiments were successful and the icon is always displayed correctly by Safari. Are you sure the mask icon is properly declared in your site? (you can run the checker for a quick review) Could you attach the SVG to this issue? (or please mail it to me if that's not possible). |
It does not display neither in Safari, Safari Technology Preview nor Firefox Developper Edition. Checker does not work as check never ends. I've send the SVG file by mail. |
Damn! Thank you for reporting. So I wanted to reproduce the issue, only to discover that I have to pay 99€ to download a beta product I'll have for free when it's ready. Procrastination suddenly became my best ally. What you observe is unexpected because Safari usually doesn't behaves like this when there is a problem with the mask icon (eg. when the
I updated the compatibility test, and somehow hacked it to compare the "classic", buggy, high resolution icon and the expected, 16x16 icon. Could you run it?
If you don't see this, it means that the resolution of the icon is not the culprit.
|
I finally installed macos Sierra (which is available for free after all). I don't reproduce the issue: the icon is displayed correctly, whatever the viewBox (16x16 or a lot more). @MoOx Could you paste your master image and the parameter you used to generate the SVG icon for Safari? Or, as an alternative, could you send me your SVG by email? |
I can't find it again. Will reopen if I get this again. |
Oh I can't close this :/ |
Fixed in branch |
Deployed a minute ago. |
Currently, the Safari mask icons created by RFG have a viewBox of 700x700:
However, it should be 16x16.
Although RFG icons do work, it would be better to strictly follow Apple's recommendations.
The text was updated successfully, but these errors were encountered: