Wrong relative URLs in generated manifest.json #270

Open
bschwarzent opened this Issue Aug 15, 2016 · 2 comments

Projects

None yet

3 participants

@bschwarzent

I prefer placing all resources generated by RFG in a seperate folder, e.g. http://www.example.com/myapp/resources/favicons. To achieve that, I use the "I cannot or I do not want to place favicon files at the root of my web site. Instead I will place them here" option and specify the relative path "resources/favicons".

This generates the following manifest.json:

{
    "name": "MyApp",
    "icons": [
        {
            "src": "resources\/favicons\/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image\/png"
        },
        {
            "src": "resources\/favicons\/android-chrome-512x512.png",
            "sizes": "512x512",
            "type": "image\/png"
        }
    ],
    "theme_color": "#ffffff",
    "display": "standalone"
}

And the following include for http://www.example.com/myapp/index.html:

...
<link rel="manifest" href="resources/icons/manifest.json">
...

This results in 404 errors because Chrome tries to access http://www.example.com/myapp/**resources/favicons/resources/favicons/**android-chrome-192x192.png (the part resources/icons appears twice in the URL).

I think, the manifest.json should not contain the specified relative prefix, because the manifest file is already at that location. The specification (https://w3c.github.io/manifest/#src-member) states, that if the src attribute contains a relative URL, it is interpreted relative to the manifest's URL.

@phbernard
Contributor

Absolutely. Thank you for reporting. I should fix this next week.

@phbernard phbernard added the bug label Aug 16, 2016
@ve3
ve3 commented Aug 17, 2016

Not just manifest.json but also wrong relative URL in browserconfig.xml too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment