New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't escape slashes in manifest.json #282

Closed
dandv opened this Issue Oct 5, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@dandv

dandv commented Oct 5, 2016

Here's the manifest.json I get for my icon:

{
    "name": "ImageCapture polyfill demo",
    "icons": [
        {
            "src": "\/icons\/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image\/png"
        },
        {
            "src": "\/icons\/android-chrome-512x512.png",
            "sizes": "512x512",
            "type": "image\/png"
        }
    ],
    "theme_color": "#ffffff",
    "display": "standalone"
}

@phbernard phbernard added this to the Package v0.14 milestone Oct 6, 2016

@phbernard

This comment has been minimized.

Show comment
Hide comment
@phbernard

phbernard Oct 6, 2016

Contributor

As this SO thread explains it, it's interesting when embedding JSON in a script tag, but it's pointless here. Slashes shouldn't be escaped in the manifest.

Contributor

phbernard commented Oct 6, 2016

As this SO thread explains it, it's interesting when embedding JSON in a script tag, but it's pointless here. Slashes shouldn't be escaped in the manifest.

@phbernard phbernard changed the title from Why are slashes backslash-escaped in manifest.json? to Don't escape slashes in manifest.json? Oct 6, 2016

@phbernard phbernard changed the title from Don't escape slashes in manifest.json? to Don't escape slashes in manifest.json Oct 6, 2016

@phbernard

This comment has been minimized.

Show comment
Hide comment
@phbernard

phbernard Nov 3, 2016

Contributor

Fixed in branch package_v0_14

Contributor

phbernard commented Nov 3, 2016

Fixed in branch package_v0_14

@phbernard

This comment has been minimized.

Show comment
Hide comment
@phbernard

phbernard Jan 18, 2017

Contributor

Deployed a minute ago.

Contributor

phbernard commented Jan 18, 2017

Deployed a minute ago.

@phbernard phbernard closed this Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment