Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't escape slashes in manifest.json #282

Closed
dandv opened this issue Oct 5, 2016 · 3 comments
Closed

Don't escape slashes in manifest.json #282

dandv opened this issue Oct 5, 2016 · 3 comments
Labels
Milestone

Comments

@dandv
Copy link

@dandv dandv commented Oct 5, 2016

Here's the manifest.json I get for my icon:

{
    "name": "ImageCapture polyfill demo",
    "icons": [
        {
            "src": "\/icons\/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image\/png"
        },
        {
            "src": "\/icons\/android-chrome-512x512.png",
            "sizes": "512x512",
            "type": "image\/png"
        }
    ],
    "theme_color": "#ffffff",
    "display": "standalone"
}
@phbernard phbernard added this to the Package v0.14 milestone Oct 6, 2016
@phbernard
Copy link
Contributor

@phbernard phbernard commented Oct 6, 2016

As this SO thread explains it, it's interesting when embedding JSON in a script tag, but it's pointless here. Slashes shouldn't be escaped in the manifest.

@phbernard phbernard changed the title Why are slashes backslash-escaped in manifest.json? Don't escape slashes in manifest.json? Oct 6, 2016
@phbernard phbernard changed the title Don't escape slashes in manifest.json? Don't escape slashes in manifest.json Oct 6, 2016
@phbernard
Copy link
Contributor

@phbernard phbernard commented Nov 3, 2016

Fixed in branch package_v0_14

@phbernard
Copy link
Contributor

@phbernard phbernard commented Jan 18, 2017

Deployed a minute ago.

@phbernard phbernard closed this Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.