Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari Mask Icon wrong units in SVG #311

Closed
an-tex opened this issue Mar 9, 2017 · 2 comments
Closed

Safari Mask Icon wrong units in SVG #311

an-tex opened this issue Mar 9, 2017 · 2 comments
Labels
bug
Milestone

Comments

@an-tex
Copy link

@an-tex an-tex commented Mar 9, 2017

The generated SVG for the Safari Mask Icon sets the svg width and height to 16pT, instead of 16pX. 16pt translates in my safari to 21px so the icon is deemed invalid and nothing is shown in a pinned tab. Works when I change it to 16px.

So it should be:

<svg version="1.0" xmlns="http://www.w3.org/2000/svg" width="16.000000px" height="16.000000px" viewBox="0 0 16.000000 16.000000" preserveAspectRatio="xMidYMid meet">

instead of:

<svg version="1.0" xmlns="http://www.w3.org/2000/svg" width="16.000000pt" height="16.000000pt" viewBox="0 0 16.000000 16.000000" preserveAspectRatio="xMidYMid meet">

@phbernard phbernard added this to the Package v0.15 milestone Apr 20, 2017
@phbernard
Copy link
Contributor

@phbernard phbernard commented Apr 20, 2017

Two things:

  • I couldn't find any (good) way to make the unit right. As far as I understand, InkScape (used from the command line) cannot do this.
  • I couldn't reliably check if the current icon (with wrong units) work or not.

In doubt, I prefer to simply rollback the change of #242 .

@phbernard phbernard added the bug label Apr 20, 2017
@phbernard
Copy link
Contributor

@phbernard phbernard commented Apr 24, 2017

Deployed a minute ago.

@phbernard phbernard closed this Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.