Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always generate browserconfig.xml #32

Closed
phbernard opened this issue Mar 25, 2014 · 2 comments
Closed

Always generate browserconfig.xml #32

phbernard opened this issue Mar 25, 2014 · 2 comments
Labels

Comments

@phbernard
Copy link
Contributor

phbernard commented Mar 25, 2014

When the user chooses to not place the favicon files in the root directory of the web site:

  • browserconfig.xml is not generated.
  • The IE11 pictures are declared directly in the HTML code.

However, this is not necessary. browserconfig.xml path can de declared. For example:

<meta name="msapplication-config" content="/path/to/browserconfig..xml" />

This would save a few bytes of HTML code.

See http://msdn.microsoft.com/en-us/library/ie/dn320426(v=vs.85).aspx

@phbernard phbernard added the bug label Mar 25, 2014
@phbernard
Copy link
Contributor Author

phbernard commented Mar 27, 2014

One exception: the user may enter a kind of template engine directive as the path (eg. <?php echo $icon_path ?>). This declaration will work in the HTML code to copy/paste, but the generated browserconfig.xml will probably be considered as a static file, not to be processed by the template engine. In that case, it will be somewhat corrupted.

This scenario should be taken into account.

@phbernard
Copy link
Contributor Author

phbernard commented Apr 16, 2014

Fixed and deployed a minute ago. This is code 0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant