Always generate browserconfig.xml #32

Closed
phbernard opened this Issue Mar 25, 2014 · 2 comments

Projects

None yet

1 participant

@phbernard
Contributor

When the user chooses to not place the favicon files in the root directory of the web site:

  • browserconfig.xml is not generated.
  • The IE11 pictures are declared directly in the HTML code.

However, this is not necessary. browserconfig.xml path can de declared. For example:

<meta name="msapplication-config" content="/path/to/browserconfig..xml" />

This would save a few bytes of HTML code.

See http://msdn.microsoft.com/en-us/library/ie/dn320426(v=vs.85).aspx

@phbernard phbernard added the bug label Mar 25, 2014
@phbernard
Contributor

One exception: the user may enter a kind of template engine directive as the path (eg. <?php echo $icon_path ?>). This declaration will work in the HTML code to copy/paste, but the generated browserconfig.xml will probably be considered as a static file, not to be processed by the template engine. In that case, it will be somewhat corrupted.

This scenario should be taken into account.

@phbernard
Contributor

Fixed and deployed a minute ago. This is code 0.7.

@phbernard phbernard closed this Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment