Skip to content

Commit

Permalink
Bluetooth: hidp: remove wrong send_report at init
Browse files Browse the repository at this point in the history
The USB hid implementation does retrieve the reports during the start.
However, this implementation does not call the HID command GET_REPORT
(which would fetch the current status of each report), but use the
DATA command, which is an Output Report (so transmitting data from the
host to the device).
The Wiimote controller is already guarded against this problem in the
protocol, but it is not conformant to the specification to set all the
reports to 0 on start.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Conflicts:
	net/bluetooth/hidp/core.c
  • Loading branch information
bentiss authored and RealJohnGalt committed Apr 27, 2016
1 parent fe26478 commit f8bf24e
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions net/bluetooth/hidp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -740,17 +740,6 @@ static int hidp_parse(struct hid_device *hid)

static int hidp_start(struct hid_device *hid)
{
struct hidp_session *session = hid->driver_data;
struct hid_report *report;

list_for_each_entry(report, &hid->report_enum[HID_INPUT_REPORT].
report_list, list)
hidp_send_report(session, report);

list_for_each_entry(report, &hid->report_enum[HID_FEATURE_REPORT].
report_list, list)
hidp_send_report(session, report);

return 0;
}

Expand Down

0 comments on commit f8bf24e

Please sign in to comment.