Skip to content

Regression: If multiple categories are selected, closing QuickFolders settings reverts to "Show All" #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RealRaven2000 opened this issue Jan 25, 2021 · 7 comments
Assignees
Labels

Comments

@RealRaven2000
Copy link
Owner

If the option to select multiple categories (by holding Shift when selecting a new category) is enabled and multiple Categories are currently selected, opening and closing the QuickFolders settings resets the view to show all folders.

Expected behavior: the currently selected categories should persist.

@RealRaven2000
Copy link
Owner Author

Quick fixes for Thunderbird 78 and Thunderbird 68:

QuickFolders-wx-5.3pre5.zip

QuickFolders-wx-4.20pre2.zip

@RealRaven2000
Copy link
Owner Author

Fixed in 5.3 - released 22/02/2021

@kimbap77
Copy link

kimbap77 commented Nov 3, 2021

I am using multiple tab categories, and now Thunderbird opens showing all my tabs (in the _ALL category). I am using QF version 5.8.2 and the following extensions: quickFilters, Quicktext, and Textmarker. My theme is Gradient Orange-Blue.

@RealRaven2000
Copy link
Owner Author

I am using multiple tab categories, and now Thunderbird opens showing all my tabs (in the _ALL category). I am using QF version 5.8.2 and the following extensions: quickFilters, Quicktext, and Textmarker. My theme is Gradient Orange-Blue.

It may be another regression - but I did test this after updating Thunderbird to 91.3 on a test profile and there it does start up with the correct category preselected:

image

I guess we need to wait for @jobisoft to implement the new session API to make this more reliable.

@RealRaven2000 RealRaven2000 reopened this Nov 3, 2021
@RealRaven2000
Copy link
Owner Author

Think I spoke too soon - let me test it with multiple categories. (I expect it should work exactly the same as the active tab category / categories are just stored in a simple string)

@RealRaven2000
Copy link
Owner Author

Think I spoke too soon - let me test it with multiple categories. (I expect it should work exactly the same as the active tab category / categories are just stored in a simple string)

Just tested that here, and again it "works for me":

image

@RealRaven2000
Copy link
Owner Author

I talked with @jobisoft today and he had developed a new API for notifying when the session has loaded. This may be helpful to start another attempt at restoring categories using the internal (ondocumented) function that restores internal states. on the other hand - any official session data (Firefox has some APIs) does not survive a restart. We are hoping that John may come up with an API or experimental API that may take of this across restarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants