-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make QuickFolders compatible with Thunderbird 91. (ESR 2021/22) #114
Comments
Quick fixes for the first two items listed above: To install, download the zip file and drag into Thunderbird Add-ons manager. This version should also be compatible with Thunderbird 78, so feel free to test there as well and leave comments below: |
Works fine! (You are very quick!) 👍🏼 |
Yeah, I already had found that grid bug earlier and only just discovered the search not working while messing around with quickFilters. That's why I decided to create a catch-all bug for Thunderbird 86 like in quickFilters, so I can hit the ground running later this year when the ESR rolls around once more. The changes aren't quite as fundamental as having to drop the legacy flag altogether (as Thunderbird 78 required) but my guess is they will be more numerous this year because Thunderbird will force developers to publish new Add-ons as "Mail extensions" - with native APIs only. Which means they can do more internal changes / refactoring and care about internal dependencies of our code less - if we still use the legacy methods of "hacking the internals" - like all my Add-ons we have to once again blame ourselves if we can't keep up. At the moment I am solving the problems with "wrapper code" - so I am writing functions that "translate" between both behaviors, but I had dropped a lot of that in Tb78 because I was forced to fork my code into a new branch - which effectively doubles my workload whenever I try to back-port bug fixes / features for Thunderbird 68. Once I release for 88 I will probably freeze all work on Thunderbird 68 because it will only have diminishing returns at that stage. |
First two items fixed in 5.3 - released 22/02/2021. Please add more defects / regressions for Tb86 / later below. |
More defects found in Tb 88:
These are caused by folder.subFolders having been changed from an nsIMutableArray to an Array. I added some wrapper code so that it will work both in Tb78 and in the newer versions as well. quickFix tested in Thunderbird 87.0b1 |
Next problem in Tb87
The patched version simply passes both so it remains backwards compatible with Tb78, too: |
Next problem in Tb87
Fixed version: |
I published Release 5.4 on ATN today
|
Super! |
an initialism for addons.thunderbird.net - where I release all my updates that are automatically deployed to my users. It used to be AMO (addons.mozilla.org). |
Here is a test version for Thunderbird 88: (install by downloading the zip wilfe and then dragging it into Thudnerbird Add-ons Manager) I hope addons.thunderbird.net will support uploading something with max-version number 8.0 so that all betas can be accepted. |
To do: create list of changes for @jobisoft to document what's changing in Thunderbird ESR 2021/22 e.g. util.moveMessages() function uses
Folder View Row Items - in this example
Copying folders: this should go through
|
To Do: revisit |
The reported changes have been added to DTN (I missed ftvItem). Thanks! |
Open items:
|
Latest test version for Thunderbird 91 (tested in Tb daily 92.0a1): To install this preview, download the zip file and drag it into Thunderbird Add-ons manager. |
|
To install this preview, download the zip file and drag it into Thunderbird Add-ons manager. |
Looks like Fresh preview with quick fix: To install this preview, download the zip file and drag it into Thunderbird Add-ons manager. Caution: contains fresh code from issue #187 - so if you haven't got any license you're a bit of a guinea pig right now. Just ironing out the kinks... |
Fixed: dragging the envelope from current folder toolbar (Navigation bar). The envelope icon represents the currently selectged emails and dragging it failed in Thunderbird 91 Test Version below: |
Another drag + drop issue I found was: #190 - this involved being able to drag the mail icon on the Current Folder toolbar (center screen) in order to make for a very quick and easy drag operation to targets such as the "recent folders" toolbar button from a constant remembered screen location. The bug is addressed in this preview version: QuickFolders-mx-5.7pre212.zip |
Implemented in 5.7 - released on 10/08/2021 |
There are a number of things that don't work in the latest beta for Thunderbird 86, so far I have discovered:
The text was updated successfully, but these errors were encountered: