Skip to content

Feature: Restrict search choices to current server / Exclude accounts from search #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
higham opened this issue Mar 7, 2021 · 15 comments
Assignees

Comments

@higham
Copy link

higham commented Mar 7, 2021

With QuickJump, QuickMove etc. in the pro version I'd like an option to restrict the completion choices
to the current server. I have two different email accounts with similar folder structures in Thunderbird.
Nostalgy++ has this feature under the completion preferences.

@RealRaven2000
Copy link
Owner

Thanks for the suggestion. There is already a way for hiding folders (and subfolders) from the search results but it can only be applied through a tab and not to a whole account. This would be done via the "Tab specific properties" under QuickFolders commands:
image

image

The actual mechanism is stored in QuickFolders "folder string" - so it isn't stored in the folders themselves but in the "tab". If I extend this behavior there would be 2 problems to solve:

  1. how to access the "Advanced Properties" setting through the same interface.
  2. If these settings are stored without showing the account / server as a tab (which it would have to do with the current UI) - how would the setting be accessed without building a completely new interface.

Existing functionality:

  • You can already configure settings that affect a referenced (by a QF tab) folder and its subfolders. So that would kind of already support the functionality if there was a UI to set it, if I extended it to the "root" folder.
  • You can hide tabs via the "Category" setting. So you wouldn't need to have a tab permanently visible for the setting to be applied.

Possible Problems:

  • Accounts do not support dragging and dropping. The UI would have to go through either the QuickFolders settings dialog or right-clicking on the account, which is conceivable. I guess Nostalgy has a listbox / dropdown within it's configuration dialog where each account can be selected? Or is it baked into Account settings? modifying account settings (or any window owned by Thunderbird) will become increasingly difficult since legacy Add-ons have been deprecated, so this method may not a good solution for the future.

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Mar 8, 2021

I have started building a prototype, since there is a lot of advanced stuff that can be configured in the search features I think it warrants that it can be in its own dialog box. This will be accessible via "Advanced Settings" under the premium features settings that enable shortcuts:

image

the initial dialog looks like this:
image

I don't want to use a listbox because they are difficult to extend with extra features (in case I need to add more account specific options later) and won't be html compliant so this would be additional work.
I want to use a grid layout for this so that the checkboxes can align underneath each other without having to make the first row (accounts) a fixed length. For every checkbox there will be a setting stored either as a separate about:config entry or baked into the folder string (which would be nicer but more dangerous for regressions)

@RealRaven2000
Copy link
Owner

Once I have a version 1 working I am going to post it here. By the way there are more settings hidden, which can only be configured at the moment by right-clicking the "quickMove" checkbox, which may potentially be added to this UI:
image

image
These settings are currently undocumented so having a UI will be a good way to make them more accessible and explain them to the users.

@higham
Copy link
Author

higham commented Mar 8, 2021

Thank you for looking into this, Axel.
Your dialog box doesn't seem to correspond to what I need, though:

When I'm on Account 1 I want Quick* commands to offer only folders on Account 1.
When I'm on Account 2 I want Quick* commands to offer only folders on Account 2.

I don't think your Advance Settings allows this.
So it would just be single dialog box:

"Limit quick* commands to current server".

Having said that, I do sometimes want to copy emails from one account to another
(I just did this and it works perfectly with hundreds of emails),
so the icing on the cake would be to have an easy way to toggle
this setting without going through these menus.

@RealRaven2000
Copy link
Owner

Thank you for looking into this, Axel.
Your dialog box doesn't seem to correspond to what I need, though:

When I'm on Account 1 I want Quick* commands to offer only folders on Account 1.
When I'm on Account 2 I want Quick* commands to offer only folders on Account 2.

That's a problem, because I just built this UI:
image

(note: only works in English locale, as I haven't translated to the other 18 locales yet, but still I thought it was what you wanted) :(
QuickFolders-wx-5.4pre50.zip

Having said that, I do sometimes want to copy emails from one account to another (I just did this and it works perfectly with hundreds of emails), so the icing on the cake would be to have an easy way to toggle this setting without going through these menus.

That's actually my main use case. I woulldn't survive without moving stuff across because I am using an old account as my "Local folders". having said that, should it exclude Local Folders as well?

@fredstluka
Copy link

Axel,

That's perfect for me! I have one primary email account, and bunch of other accounts. I pretty much NEVER want to file anything away anywhere except the primary account. But, I DO often move stuff from the other accounts to the primary.
So, I'd just check the boxes for all of the other accounts. Thanks!

--Fred

I have started building a prototype, since there is a lot of advanced stuff that can be configured in the search features I think it warrants that it can be in its own dialog box. This will be accessible via "Advanced Settings" under the premium features settings that enable shortcuts:

image

the initial dialog looks like this:
image

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Mar 9, 2021

Here is a test version. It was bit more difficult because I also had to exclude results from the folder tabs array.
On top is the original feature request (restrict to account of current folder)
Below that is a list of servers that can be excluded from search results:

image

Looks like I have problems uploading, let me try again...

QuickFolders-wx-5.4pre63.zip

@fredstluka
Copy link

fredstluka commented Mar 12, 2021 via email

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Mar 12, 2021

Axel, Perfect!  I checked the checkboxes for all accounts except my main one.  Worked exactly as desired.  Thanks!

--Fred ------------------------------------------------------------------------ Fred Stluka -- http://bristle.com -- Glad to be of service! Open Source: Without walls and fences, we need no Windows or Gates. ------------------------------------------------------------------------

Cool - note that there is no need to check IRC / newsgroups because they will actually not be listed in the final version (see #119 for an up to date version)

@fredstluka
Copy link

fredstluka commented Mar 12, 2021 via email

@RealRaven2000
Copy link
Owner

Axel, Does that include RSS feeds?  I AM able to drag email messages to them, and able to move them there via QuickMove.  I don't see any reason to change that.

I wouldn't think so it's actually based on a server flag:
server.canFileMessagesOnServer

So basically if you cannot copy messages there it's not going to be listed (at least to my own understanding)

@fredstluka
Copy link

fredstluka commented Mar 13, 2021 via email

@RealRaven2000
Copy link
Owner

Implemented in 5.4 - Released 18/03/2021

@RealRaven2000
Copy link
Owner

I found a bug - when I activate the restriction to the current server I still see suggestions to create new subfolders on other servers if only parent matches are found - logging this in #140

@RealRaven2000
Copy link
Owner

Closing as #140 is now also addressed in the latest official releases (5.5 and 4.21.2)

@RealRaven2000 RealRaven2000 changed the title Feature request: restrict completion choices to current server Feature: Restrict search choices to current server / Exclude accounts from search May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants