In mail tab, quickMove reopens mail in new tab after moving - should go to next unread mail instead

[fredstluka]

Shift-M works fine when I'm looking at a list of messages.

But sometimes, I hit Enter while looking at a list of messages, to see a single message in its own Thunderbird tab.

Then, when I hit Shift-M while looking at that message in a Thunderbird tab, it moves the message as expected. That causes the Thunderbird tab to show the next message. Perfect!

BUT, then a new Thunderbird tab is opened, showing the message I just moved. Not what I wanted. I wanted to just see the next message in the previously existing tab. No new tab is desired. I'm done with the old message. I read it and filed it away. Don't need to see it again.

Also, it's confusing because the net visible effect is to keep seeing the same message, not noticing that a new tab has been created to house it. So, it looks at first as though the Shift-M did NOT move the message.

--Fred

Edit: Corrected typo: "next visible effect" --> "net visible effect"
--Fred

[RealRaven2000]

This area (single tab viewing and navigation from there) isn't well tested, guess I have to do more of that. In my workflow I only open emails in single tabs if need to store them for later (so they remain on screen when I restart my Computer / next day). I did some improvements in the area when opening mails in their own window, but I think I need to do a lot more testing to make this useful. I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful.

[fredstluka]

[I moved this comment to a separate ticket #138. --Fred] Axel, Yeah, I prefer to open single mails in their own windows instead of their own tabs.  I did it that way for many years. But QuickFolders doesn't work at all from a single message window. Here are my notes on how and why I changed that in Thunderbird preferences:         - General Preferences           - Reading & Display             - Open messages in = new window (was new tab)               - [Sat 1/16/2021]                 Changed back to new tab.  Gives me just as much room to                 read it as new window, still closes via Cmd-W, and now                 QuickFolders commands work for filing away messages.               - [Tue 1/19/2021]                 One downside is that when I leave and return the tab, it                 scrolls back to the top.  Doesn't remember my scroll                 position like a separate window does.

…

--Fred ------------------------------------------------------------------------ Fred Stluka -- http://bristle.com -- Glad to be of service! Open Source: Without walls and fences, we need no Windows or Gates. ------------------------------------------------------------------------

On 4/6/21 9:12 AM, RealRaven2000 wrote: This area (single tab viewing and navigation from there) isn't well tested, guess I have to do more of that. In my workflow I only open emails in single tabs if need to store them for later (so they remain on screen when I restart my Computer / next day). I did some improvements in the area when opening mails in their own window, but I think I need to do a lot more testing to make this useful. I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKWRN3U6J6XHBRNAY2GUDTHMCDBANCNFSM42NT4YAA>.

[fredstluka]

Axel,

This area (single tab viewing and navigation from there) isn't well tested, guess I have to do more of that.

Yeah, is there a way for you to do automated regression tests? As a software developer, I couldn't live without them.  But they're harder to do when testing a GUI than a CLI or an API.

…

--Fred ------------------------------------------------------------------------ Fred Stluka -- http://bristle.com -- Glad to be of service! Open Source: Without walls and fences, we need no Windows or Gates. ------------------------------------------------------------------------

On 4/6/21 9:12 AM, RealRaven2000 wrote: This area (single tab viewing and navigation from there) isn't well tested, guess I have to do more of that. In my workflow I only open emails in single tabs if need to store them for later (so they remain on screen when I restart my Computer / next day). I did some improvements in the area when opening mails in their own window, but I think I need to do a lot more testing to make this useful. I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKWRN3U6J6XHBRNAY2GUDTHMCDBANCNFSM42NT4YAA>.

[fredstluka]

Axel,

I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful.

I'd expect it to do the same as if I deleted the message while viewing it in a tab.  In that case, Thunderbird automatically shows the next message in the folder, or the next message in the search list, or in the conversation, or whatever set of messages I was looking at when I hit Enter to open the message in its own tab. Should also respect the behavior of Thunderbird that is specified by: - Preferences   - General     - Close message window/tab on move or delete

…

--Fred ------------------------------------------------------------------------ Fred Stluka -- http://bristle.com -- Glad to be of service! Open Source: Without walls and fences, we need no Windows or Gates. ------------------------------------------------------------------------

On 4/6/21 9:12 AM, RealRaven2000 wrote: This area (single tab viewing and navigation from there) isn't well tested, guess I have to do more of that. In my workflow I only open emails in single tabs if need to store them for later (so they remain on screen when I restart my Computer / next day). I did some improvements in the area when opening mails in their own window, but I think I need to do a lot more testing to make this useful. I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKWRN3U6J6XHBRNAY2GUDTHMCDBANCNFSM42NT4YAA>.

[RealRaven2000]

Axel,
I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful.
I'd expect it to do the same as if I deleted the message while viewing it in a tab. 

Not me. Because you are not in the context of a list when you open a single message window - you don't see a list. But having said that, you can add the Previous and Next buttons to the single message toolbar and navigate from there. Anyway for that reason i am treating this as a "new feature" request and not as gap of something that should always have been in QuickFolders. And I don't even consider it as the expected / default behavior even though I can understand that it would be very utilitarian for the way you use Thunderbird.

So from my POV this is a nice additional feature, that the large majority of users won't expect or use, and possibly a lot of work for me. Still a nice feature. The CEO of postbox (who strictly implements features based on the 80/20 approach - if it doesn't benefit 80% of the users it's not worth wasting money on it) would certainly not implement it because it doesn't make economical sense. If I implement it then I have to be convinced that nothing else on the wishlist is more important / helpful - I need to convert more users to licensees and put a lot of energy into this first, and naturally features that are intuitively easier to find and use will take precedence.

Still, I would prefer the new functionality too. And there should be the options "go to next message and go to next unread message" - in the later case, what would happen if no unread messages are left? It's a complicated feature when you start thinking about it.

In that case, Thunderbird automatically shows the next message in the folder, or the next message in the search list, or in the conversation, or whatever set of messages I was looking at when I hit Enter to open the message in its own tab. Should also respect the behavior of Thunderbird that is specified by: - Preferences   - General     - Close message window/tab on move or delete

Didn't find it at first, I believe you mean

• Preferences
  • Reading & Display
    • Close message window/tab on move or delete

Edit: ok. What happens if you don't have it active without QuickFolders disabled? Does it do the correct / expected thing then??

[RealRaven2000]

So I was looking at the implementation, turns out it was actually myself who reopened the tab after moving the email (behavior was by design) - see in quickfolders-quickMove.js function execute().

  if (messageDb && !isCopy) {
    // reusing the existing Tab didn't work so we close & re-open msg from the new location.
    // let tab = (QuickFolders.Util.Application=='Thunderbird') ? tabmail.selectedTab : tabmail.currentTabInfo;
    // currentTab.folderDisplay.selectMessage(msgHdr, true);
    setTimeout( 
      function() {
        let msgHdr = messageDb.getMsgHdrForMessageID(theMessage);
        util.logDebugOptional('quickMove', 'reopen mail in tab:' + msgHdr.mime2DecodedSubject );
        QuickFolders.Util.openMessageTabFromHeader(msgHdr);
      }, 1200);
  }

I made this optional now and turned it off by default. I also added "go to the next unread mail" as a configurable option (no UI yet) and turned that one on by default. Test Version for Thunderbird 78:

QuickFolders-wx-5.5pre10.zip

New configuration settings:

extensions.quickfolders.quickMove.reopenMsgTabAfterMove = false
extensions.quickfolders.quickMove.gotoNextUnreadAfterMove = true

So this should do the desired behavior of the OP: " I wanted to just see the next message in the previously existing tab."

[RealRaven2000]

Added UI to advanced quickMove settings and translated into 17 languages (thanks, google translate):

QuickFolders-wx-5.5pre15.zip

@fredstluka please test when you get time? For the old (unwanted) behavior you would have to check boxes the opposite way than in the screenshot.

PS: Not going to create a dedicated UI for the Thunderbird 68 version because I have no "quickMove Advanced Settings" dialog there. If people want to change these advanced settings, they will have to right-click on the quickMove checkbox in the premium features box on the QF Pro tab.

[fredstluka]

Axel, Wow!  Thanks for the quick responses to all of these bugs and feature requests.  I've never seen such good customer support anywhere, in my entire 38-year career.  There are one or two extraordinary vendors that send me fixes or new features within a week or so, but never the same or next day like you've been doing.  Very nice!!! OK.  I installed QuickFolders-wx-5.5pre15.zip <https://github.com/RealRaven2000/QuickFolders/files/6313285/QuickFolders-wx-5.5pre15.zip>. Looks great!  Thanks!  Without changing either of the new checkboxes in the settings panel, it does exactly what I wanted. Some minor quirks: a. It moves to the next message, not the next UNREAD message.     That's fine with me.  Exactly what I wanted, but not what I     thought you said it would do. b. The new settings checkbox "Display next unread mail after      moving current one" seems to have no effect.  It always      goes to the next message, not the next unread message.      That's also fine with me, but perhaps not what you wanted. c. After moving the message, quickMove seems to leave the     keyboard focus in the search text box.  The box vanishes,     but typing keystrokes still causes the menu to appear and     to change appropriately based on the chars you type, even     though you can't see them.  Also, Shift-M (to move the next     message which his now appeared in the tab) doesn't work.     Probably because it's also being directed to the text box.     Also, Cmd-Z (undo, to move the message back) doesn't work.     Probably because it's also being directed to the text box.     Clicking in the message box (to move focus away from the     text box) makes everything start working properly again. I did some pretty thorough testing, since I thought I saw odd behavior once or twice.  But it was all explained by the above, I think. Here are the tests I did, all of which came out perfect.  Thanks! I compared QF quickMove with the native TB ways to move a message that is displayed alone in a tab: - Menu: Message | Move To - Menu: Message | Move to "..." Again - Shortcut: Opt-Cmd-M - Toolbar: File - Right-Click: Move To - Right-Click: Move to "..." Again which all behave identically. And also to the native TB Delete (via Mac Delete or Windows Backspace key) which behaves identically with regard to which message gets shown next. I tried various scenarios involving a TB tab that shows a single message and compared the behavior of the native TB move vs QF quickMove. 1. When I'm looking at an unfiltered folder and open a single     message in a new tab, then move that message to a new     folder, or delete it:     - TB shows the next message     - QF does the same.  Perfect! 2. When I'm looking at a FILTERED folder (I typed a string in the     "Filter these messages" text box above the list of messages,     of hit Cmd-Shift-K, to see only some of the messages in the     folder), and open a single message in a new tab, then move     that message to a new folder, or delete it:     - TB shows the next filtered message     - QF does the same.  Perfect! 3. When I'm looking at a conversation view of messages from     multiple different folders, and open a single message in a new     tab, then move that message to a new folder, or delete it:     - TB shows the next message in the conversation from whatever folder     - QF does the same.  Perfect! 4. When I'm looking a list of messages from multiple different     folders generated by "Show results as list" after doing a search,     and open a single message in a new tab, then move that     message to a new folder, or delete it:     - TB shows the next message in the list from whatever folder     - QF does the same.  Perfect! 5.  Same as (1), but it's the last message in the folder     - TB shows the previous message, since there is no next message     - QF does the same.  Perfect! 6.  Same as (2), but it's the last filtered message in the folder     - TB shows the previous filtered message, not the message that        would be next if the filter were ignored     - QF does the same.  Perfect! 7.  Same as (3), but it's the last message in the conversation     - TB shows the previous message in the conversation, since        there is no next message     - QF does the same.  Perfect! 8.  Same as (4), but it's the last message in the search results list     - TB shows the previous message in the list, since there is no        next message     - QF does the same.  Perfect! 9.  Same as (1), but it's the only message in the folder     - TB closes the tab since there are no more messages     - QF does the same.  Perfect! 10.  Same as (2), but it's the only filtered message in the folder     - TB closes the tab since there are no more filtered messages     - QF does the same.  Perfect! 11.  Same as (3), but it's the only message in the conversation     - TB leaves the tab open, but empty since there are no more        message in the conversation.  Oddly inconsistent with (9)        and (10), but OK.  I won't bother reporting it as a bug to        Mozilla.     - QF does the same.  Perfect match with TB! 12.  Same as (4), but it's the only message in the search results list     - TB leaves the tab open, but empty since there are no more        message in the list.   Oddly inconsistent with (9) and (10), but        OK.  I won't bother reporting it as a bug to Mozilla.     - QF does the same.  Perfect match with TB! [Edits: 4/16/2021 5:10pm] - Fixed typo: "Opt-Cmd-M" --> "Opt-Cmd-M" - Emphasized that the behavior of native TB delete is the same as that of native TB move with respect to which message is shown next. --Fred [Edits: 4/16/2021 5:30pm] - Enumerated the native TB ways to move a message that is displayed alone in a tab.

…

--Fred ------------------------------------------------------------------------ Fred Stluka -- http://bristle.com -- Glad to be of service! Open Source: Without walls and fences, we need no Windows or Gates. ------------------------------------------------------------------------

On 4/12/21 3:38 PM, RealRaven2000 wrote: Axel, I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful. I'd expect it to do the same as if I deleted the message while viewing it in a tab. Not me. Because you are not in the context of a list when you open a single message window - you don't see a list. But having said that, you can add the Previous and Next buttons to the single message toolbar and navigate from there. Anyway for that reason i am treating this as a "new feature" request and not as gap of something that should always have been in QuickFolders. And I don't even consider it as the expected / default behavior even though I can understand that it would be very utilitarian for the way you use Thunderbird. So from my POV this is a nice additional feature, that the large majority of users won't expect or use, and possibly a lot of work for me. Still a nice feature. The CEO of postbox (who strictly implements features based on the 80/20 approach - if it doesn't benefit 80% of the users it's not worth wasting money on it) would certainly not implement it because it doesn't make economical sense. If I implement it then I have to be convinced that nothing else on the wishlist is more important / helpful - I need to convert more users to licensees and put a lot of energy into this first, and naturally features that are intuitively easier to find and use will take precedence. Still, I would prefer the new functionality too. And there should be the options "go to next message and go to next unread message" - in the later case, what would happen if no unread messages are left? It's a complicated feature when you start thinking about it. In that case, Thunderbird automatically shows the next message in the folder, or the next message in the search list, or in the conversation, or whatever set of messages I was looking at when I hit Enter to open the message in its own tab. Should also respect the behavior of Thunderbird that is specified by: - Preferences   - General     - Close message window/tab on move or delete Didn't find it at first, I believe you mean * Preferences o Reading & Display + Close message window/tab on move or delete ok. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKWRJNR6HWU4FB6J6JR7DTIND5DANCNFSM42NT4YAA>.

[fredstluka]

Axel, I just realized that GitHub does NOT keep me fully informed via email.  It sends email whenever a comment is posted or a ticket is closed, but NOT: - When a ticket title is changed - When a comment is edited - When even the original problem description is edited (I think) - When a ticket is pinned - Others? For example, I edited the original description of this ticket to correct a typo, and added a note at the bottom of the description saying the following.  I got no email from that.  Did you?

Edit: Corrected typo: "next visible effect" --> "net visible effect" --Fred

Also, you added these 2 additional bits of text to comments that you'd already added.  I got email for the original comments, but none for the edits.  So I could easily have never seen edits.  Did you get email from them? 1:

Edit: ok. What happens if you don't have it active without QuickFolders disabled? Does it do the correct / expected thing then??

2:

PS: Not going to create a dedicated UI for the Thunderbird 68 version because I have no "quickMove Advanced Settings" dialog there. If people want to change these advanced settings, they will have to right-click on the quickMove checkbox in the premium features box on the QF Pro tab.

Also, in (1) above, I'm not sure what you mean by "don't have it active without QuickFolders disabled".  Please explain. Thanks! --Fred ------------------------------------------------------------------------ Fred Stluka -- http://bristle.com -- Glad to be of service! Open Source: Without walls and fences, we need no Windows or Gates. ------------------------------------------------------------------------

…

On 4/12/21 3:38 PM, RealRaven2000 wrote: Axel, I would have Shift-M (moving a mail while looking at it in a tab) - expected to "stay there and do nothing" or "close the tab" - not necessarily do some automatic advancing to the next unread mail, but again I can see that it would be useful. I'd expect it to do the same as if I deleted the message while viewing it in a tab. Not me. Because you are not in the context of a list when you open a single message window - you don't see a list. But having said that, you can add the Previous and Next buttons to the single message toolbar and navigate from there. Anyway for that reason i am treating this as a "new feature" request and not as gap of something that should always have been in QuickFolders. And I don't even consider it as the expected / default behavior even though I can understand that it would be very utilitarian for the way you use Thunderbird. So from my POV this is a nice additional feature, that the large majority of users won't expect or use, and possibly a lot of work for me. Still a nice feature. The CEO of postbox (who strictly implements features based on the 80/20 approach - if it doesn't benefit 80% of the users it's not worth wasting money on it) would certainly not implement it because it doesn't make economical sense. If I implement it then I have to be convinced that nothing else on the wishlist is more important / helpful - I need to convert more users to licensees and put a lot of energy into this first, and naturally features that are intuitively easier to find and use will take precedence. Still, I would prefer the new functionality too. And there should be the options "go to next message and go to next unread message" - in the later case, what would happen if no unread messages are left? It's a complicated feature when you start thinking about it. In that case, Thunderbird automatically shows the next message in the folder, or the next message in the search list, or in the conversation, or whatever set of messages I was looking at when I hit Enter to open the message in its own tab. Should also respect the behavior of Thunderbird that is specified by: - Preferences   - General     - Close message window/tab on move or delete Didn't find it at first, I believe you mean * Preferences o Reading & Display + Close message window/tab on move or delete ok. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKWRJNR6HWU4FB6J6JR7DTIND5DANCNFSM42NT4YAA>.

[RealRaven2000]

I installed QuickFolders-wx-5.5pre15.zip https://github.com/RealRaven2000/QuickFolders/files/6313285/QuickFolders-wx-5.5pre15.zip. Looks great!  Thanks!  Without changing either of the new checkboxes in the settings panel, it does exactly what I wanted.

Some minor quirks: a. It moves to the next message, not the next UNREAD message.     That's fine with me. 

not what I wanted. I have to fix that or change all my translations. But I think going to the unread message makes much more sense when you open an isolated special message out of a big list. What are the chances that you want to see exactly the next one?

Exactly what I wanted, but not what I     thought you said it would do. b. The new settings checkbox "Display next unread mail after      moving current one" seems to have no effect.  It always      goes to the next message, not the next unread message.      That's also fine with me, but perhaps not what you wanted. c. After moving the message, quickMove seems to leave the     keyboard focus in the search text box.  The box vanishes,     but typing keystrokes still causes the menu to appear and     to change appropriately based on the chars you type, even     though you can't see them.  Also, Shift-M (to move the next     message which his now appeared in the tab) doesn't work.     Probably because it's also being directed to the text box.     Also, Cmd-Z (undo, to move the message back) doesn't work.     Probably because it's also being directed to the text box.     Clicking in the message box (to move focus away from the     text box) makes everything start working properly again. I did some pretty thorough testing, since I thought I saw odd behavior once or twice.  But it was all explained by the above, I think. Here are the tests I did, all of which came out perfect.  Thanks! I compared it with the native behavior of TB's Message menu items: - Move To - Move to "..." Again (Opt-Shift-M) I tried various scenarios involving a TB tab that shows a single message and compared the behavior of the native TB move vs QF quickMove. 1. When I'm looking at an unfiltered folder and open a single     message in a new tab, then move that message to a new     folder:     - TB shows the next message     - QF does the same.  Perfect! 2. When I'm looking at a FILTERED folder (I typed a string in the     "Filter these messages" text box above the list of messages,     of hit Cmd-Shift-K, to see only some of the messages in the     folder), and open a single message in a new tab, then move     that message to a new folder:     - TB shows the next filtered message     - QF does the same.  Perfect! 3. When I'm looking at a conversation view of messages from     multiple different folders, and open a single message in a new     tab, then move that message to a new folder:     - TB shows the next message in the conversation from whatever folder     - QF does the same.  Perfect! 4. When I'm looking a list of messages from multiple different     folders generated by "Show results as list" after doing a search,     and open a single message in a new tab, then move that     message to a new folder:     - TB shows the next message in the list from whatever folder     - QF does the same.  Perfect! 5.  Same as (1), but it's the last message in the folder     - TB shows the previous message, since there is no next message     - QF does the same.  Perfect! 6.  Same as (2), but it's the last filtered message in the folder     - TB shows the previous filtered message, not the message that        would be next if the filter were ignored     - QF does the same.  Perfect! 7.  Same as (3), but it's the last message in the conversation     - TB shows the previous message in the conversation, since        there is no next message     - QF does the same.  Perfect! 8.  Same as (4), but it's the last message in the search results list     - TB shows the previous message in the list, since there is no        next message     - QF does the same.  Perfect! 9.  Same as (1), but it's the only message in the folder     - TB closes the tab since there are no more messages     - QF does the same.  Perfect! 10.  Same as (2), but it's the only filtered message in the folder     - TB closes the tab since there are no more filtered messages     - QF does the same.  Perfect! 11.  Same as (3), but it's the only message in the conversation     - TB leaves the tab open, but empty since there are no more        message in the conversation.  Oddly inconsistent with (9)        and (10), but OK.  I won't bother reporting it as a bug to        Mozilla.     - QF does the same.  Perfect match with TB! 12.  Same as (4), but it's the only message in the search results list     - TB leaves the tab open, but empty since there are no more        message in the list.   Oddly inconsistent with (9) and (10), but        OK.  I won't bother reporting it as a bug to Mozilla.     - QF does the same.  Perfect match with TB!

I am having trouble editing the above on github - it's lost all formatting when I quoted it - I guess because it is super long. If I recall correctly you also noticed in that wall of text above somewhere that the search box still has focus, which is definitely not intended. I already have 4.21 submitted for review and retracted it after I read that, because it's very bad to have an invisible textbox reacting to text input!
So here is a fixed version that addresses both problems (for Tb78) - I am setting focus to the single message straight after moving. I also notice that the keyboard shorcut "N" (next email) simply closes the single message tab - behavior that seems to come straight down from Thunderbird, so I am not going to interfere there - I don't want to reinvent all the wheels on this app.

QuickFolders-wx-5.5pre68.zip