Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickMove - no folder suggestions while viewing in searched list (search results / open msg in conversation) - Tb78 #136

Closed
fredstluka opened this issue Apr 9, 2021 · 18 comments
Closed

quickMove - no folder suggestions while viewing in searched list (search results / open msg in conversation) - Tb78 #136

fredstluka opened this issue Apr 9, 2021 · 18 comments
Assignees
@RealRaven2000
Labels
bug regression Tb78

Comments

@fredstluka
Copy link

fredstluka commented Apr 9, 2021 •
edited

I use Shift-M, Shift-T, and Shift-J all the time. Mostly when looking at a list of emails.

But every now and then, I hit Cmd-Shift-O when looking at a list of emails, to see the entire threaded conversation across multiple folders.

While looking at that threaded conversation, I try to use Shift-M, Shift-T, or Shift-J, to move or copy one of the messages of the thread to a different folder. Or to jump to that folder.

In that case, Shift-M, Shift-T, or Shift-J pops up a text box as usual, but when I type into the text box, it shows no dropdown menu. And when I hit down-arrow, it shows the previous folder that I did a move, copy or jump to. Totally ignoring the chars I've now typed into the text box.

Odd...
--Fred

[4/9/2012 Edit]
My workaround is to right-click the message in the conversation, and choose "Open Message in Containing Folder". Then use Shift-M, Shift-T, or Shift-J as usual.

--Fred
@fredstluka fredstluka mentioned this issue Apr 12, 2021
Closed
@RealRaven2000 RealRaven2000 changed the title Shift-M, Shift-T, and Shift-J misbehave after Cmd-Shift-O... Shift-M, Shift-T, and Shift-J misbehave when viewing mails in searched list (search results opened in list) Apr 12, 2021
@RealRaven2000
Copy link
Owner

RealRaven2000 commented Apr 12, 2021 •
edited

I use Shift-M, Shift-T, and Shift-J all the time. Mostly when looking at a list of emails.

But every now and then, I hit Cmd-Shift-O when looking at a list of emails, to see the entire threaded conversation across multiple folders.

Ok. I never used Cm=Shift-O (my Windows PC doesn't have a Cmd key) but now I believe I understand it's a quickSearch turned into a virtual mail search list? Basically something that comes up after clicking "Open email as list"? I have changed the title along those lines so be more accessible. describing a bug based on three keyboard shortcuts is a nightmare and probably didn't motivate me to read your description in full detail. (Plus that fact that you tend to submit multiple issues at once which overwhelms my capacity)

image

And you want to move mails from there... I think Thunderbird (or my code) somehow has problems determining the original folder "we are in now". I need to check what I am doing here, but generally it should get the source folder(s) from the actual emails hightlighted. Except it does this really STUPID assumption that the first email in the list gives the folder (and that the other highlighted emails are in the same folder).

At least that is my understanding of now without looking at old code for an hour.

@RealRaven2000
Copy link
Owner

Ok, I can reproduce but only on Thunderbird 78. In error console I see this exception:

image

So that's definitely a great starting point to work from. usually it's a good idea to look into JS error console when something stops working first.

@RealRaven2000
Copy link
Owner

So, this seems to be a side effect of the new feature to exclude accounts from the search results. or rather the feature not to allow moving from the current account to another, here are the lines where it fails:

  if (isQuickJumpOrMove) {
    currentFolder = util.CurrentFolder;
    if (!currentFolder) isQuickJumpOrMove = false; // can't determine current account
    currentServer = currentFolder.server ? currentFolder.server.key : null;
    quickMoveSettings.loadExclusions(); // prepare list of servers to omit
  }

even if I fix this it will probably break the "don't move mail to other servers" feature. It's tricky because you may have multiple mails in different accounts selected...

@RealRaven2000
Copy link
Owner

quick fix version for Thunderbird 78:

QuickFolders-wx-5.5pre3.zip

Note: this should still honor the excluded accounts, but the advanced search setting "Only show results from current mail account" will not work because in a search there is no current folder, and this is what that setting is based on!

@RealRaven2000 RealRaven2000 self-assigned this Apr 13, 2021
@RealRaven2000 RealRaven2000 changed the title Shift-M, Shift-T, and Shift-J misbehave when viewing mails in searched list (search results opened in list) quickMove - no folder suggestions while viewing in searched list (search results / open msg in conversation) - Tb78 Apr 13, 2021
@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@RealRaven2000
Copy link
Owner

Axel, Tried the new zip file.  Works perfectly.  Thanks! As you said, the "Only show results from current mail account" option does not work from a conversation view. But does still work from regular mail folders.  That's fine with me because I don't use that feature.  Instead, I mark all but one of my accounts as to be excluded. Frank, does that fix all of your related problems too? If so, I think you can close the ticket, Axel. Thanks!

Thanks - I will close this issue once I officially release QuickFolders 5.5 so that people will see this one as active in the meantime and are able to test the fix above themselves. By the way you could have saved some time by visiting the github issue and reply from the bottom - rather than replying to every comment in chronological order.

There should be an option to get a copy of your own comments sent to you on github if you reply from here, which would fulfill your archivary needs... Otherwise (if you stick to replying from email) please snip out as much as you can (e.g. appelations / signatures and full on quoted threads are unnecessaryk, just clutter the issue pages and make them less accessible for others).

@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@fredstluka fredstluka mentioned this issue Apr 16, 2021
Closed
@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@RealRaven2000
Copy link
Owner

At GitHub, you can't even nest comments under other comments, so it all comes out as one long un-indented list of comments. Bummer!  But most bug tracking systems seem to be like that. I think even Jira doesn't support nested comments.

let's test that

I just inserted the above by using two > , so it is possible with markdown

I generally prefer to work from email rather than directly at the GitHub web site.  But, yeah, I could trim out some of the quoted stuff when it's not relevant.

My .sig file shouldn't be a problem at GitHub, and same for allowing Thunderbird to append a copy of the message I'm replying to, because GitHub shows only the email without those unless you click on the "..." button to see it all, right? Like with this message.  The last line you should see at GitHub is this one.  True?

yes, this is what I see:

image

but I usually would go in (on the website) and delete all that to keep it really clean. Once I learned markdown I was quite happy because I don't really want all my signature and info and included thunderbird bitmap on here.

@fredstluka
Copy link
Author

fredstluka commented Apr 16, 2021 via email

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Apr 18, 2021 •
edited

Fixed in in 5.5.1 / 4.21.3 published today

@RealRaven2000
Copy link
Owner

5.5.1 published today which implements this for Thunderbird 78 users.

@fredstluka
Copy link
Author

fredstluka commented Apr 28, 2021 via email

@RealRaven2000
Copy link
Owner

Axel,
5.5.1 published today which implements this for Thunderbird 78 users.

This version didn't install itself automatically or prompt me or anything.  When I saw this email, I went manually to the TB Add-ons manager and told it to check for updates.  I haven't had to do that in the past, but maybe I just didn't wait long enough?

It should auto-update (I just tested it by installing 5.5 and then restarted and ran "check for updates" and it updated to 5.1 - it is possible that you installed a preview version which was tagged as 5.6preXX before I decided to publish the patch and the mechanism will never downgrade your version.

Then the splash screen appeared, saying it was updated to 5.5.1. The splash screen showed me a button to see "What's New" in more details.  That took me to: - https://quickfolders.org/version.html?user=pro#5.5.1 where I saw:     "Changed folder tree shortcut from F7 to F9 (consistent with     Thunderbird 68). Push F0 to make the folder tree visible or     quickly hide it." Questions: 1. How do I get the splash screen to re-appear?  I clicked     "What's New" before I finished reading it. 2. Is the F0 above a typo? 

Typo! I fixed that, thanks for noticing.

Should be F9 perhaps?

  1. Is there an alternate key to show/hide the folder tree?     Sounds like a useful feature, but F9 is already used for     another purpose Mac-wide, and I'd rather not change that.  F7 would be fine. Thanks!

I saw that it had been changed at some stage to F7 and I had forgotten about it so I changed it back. Obviously I hadn't documented that properly, but I must have made the change at some stage for my Mac users. I think the best way forward would be to make it configurable - that would also be a step forward to increase visibility for the feature. Feel free to open a new issue for that one in case I forget it!

@fredstluka fredstluka mentioned this issue Apr 28, 2021
Open
@fredstluka
Copy link
Author

fredstluka commented Apr 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RealRaven2000 RealRaven2000

Labels
bug regression Tb78
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fredstluka @RealRaven2000