Skip to content

quickJump : Restriction to current server suggests creating new subfolder unexpectedly #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RealRaven2000 opened this issue Apr 17, 2021 · 2 comments

Comments

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Apr 17, 2021

I found a bug relating to issue #118 - when I activate the restriction to the current server I still see suggestions to create new subfolders on other servers if only parent (no child) matches are found. In this example I am trying to move a mail from "Rakuten TV" and create a new folder rakuten:

image

If there is an existing folder match it does not display the invalid option of creating a new folder across in Local Folders:

image

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Apr 17, 2021

quick fix version:

QuickFolders-wx-5.5pre74.zip

patch content: I had to add a truthy second paremeter to the folder iterator of QuickFolders.Interface.findFolderName() :

for (let folder of util.allFoldersIterator(isFiling, isQuickJump)) {
  addIfMatch(folder, matches.parentString || parentString, parents);
}

This will only work in a folder view or in a single message tab - it doesn't work in a "view message in conversation" or "search results" view because QuickFolders cannot determine a current folder in that case; this technical limitation is by design.

@RealRaven2000
Copy link
Owner Author

Fixed in 5.5 published today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant