Skip to content

Toolbar in single message tab not showing #174

Closed

Description

@PeterW-gif

Since the update today (version 5.6.5) when I open a single message tab the quickfolders toolbar is not showing. I can invoke it by clicking on 'View; toolbars and then clicking Quickfolders toolbar'. Then it shows Ok, but next time I open a single message tab is has gone again and I have to repeat the above procedure.

Activity

  1. RealRaven2000 commented on Jul 6, 2021

    @RealRaven2000
    Owner

    It works for me, can you check the following settings in QuickFolders Preferences / Advanced:

    image

  2. self-assigned this
    on Jul 6, 2021
  3. RealRaven2000 commented on Jul 6, 2021

    @RealRaven2000
    Owner

    I may have misunderstood. thought you were talking about current folder bar in message windows. How do you use the main toolbar when in a single message tab? Do you actually use the message tab to open other folders from here? I believe I did some changes in 5.5 back in April (or maybe even earlier) but I guess you weren't updated because of if this bug.

    Related bugs (affecting single message tabs) / changes:
    [issue #84]

    [web extension migration] Improved many functions that worked via accessing the "most recent Thunderbird window" and replaced them with event notifications that propagate to every window. This uses the Notification Tool library and the background script (a mechanism of the new API based "mail extensions" model).

    This way all Thunderbird windows (if you work from multiple windows) will be updated correctly when doing one of the following actions. All these now work simultaneously and update in multiple Thunderbird windows:

    • ...
    • change options of where to display the Current Folder Bar (main window, message tab, single message window)
  4. RealRaven2000 commented on Jul 6, 2021

    @RealRaven2000
    Owner

    Here is a test version with a quick fix. To activate the desired behavior (main toolbar remains visible in single message tabs) open config editor, and search fir "hideInSingleMessage", toggle it to false:

    image

    You can install this prerelease:
    QuickFolders-mx-5.6.6pre3.zip

    ..by downloading the zip file and then dragging it into the Thunderbird Add-ons Manager.

  5. PeterW-gif commented on Jul 6, 2021

    @PeterW-gif
    Author

    Ok first re your latest email I tried to download the pre-release you sent me the link to but just got an error message saying the site can't be reached, followed by lots of text and ending with "might be temporarily down or it may have moved permanently to a new web address"

    Coming back to the problem I reported I first I did check that the settings options you sent me were both ticked before sending the first ticket. This was on my Windows 10 PC but I've just checked it on my MacBook and initially the toolbar was showing on the single message tab there. But then I saw your add-on hadn't been updated on the MacBook, so I updated it and the toolbar then disappeared. So it's definitely something with your latest update.

    In more detail then, I have the Inbox tab with the quick folders toolbar displaying Ok. I click on a message which then opens in a new tab but now the toolbar is not showing. I go to 'View, Toolbars, Quickfolders toolbar' which is unticked, so I tick it. Now the toolbar displays Ok and if I then click 'Next' on the main (mail) toolbar to view the next message it remains showing.

    But if I then close that tab, go back to the Inbox tab and click on another message, when the tab opens again, the toolbar has disappeared again and when I go to 'View, Toolbars, Quickfolders toolbar' again I find it unticked again.

    And this has definitely just started happening since your latest update

    I am on the latest version of Thunderbird 78.11.0 on both machines.

  6. PeterW-gif commented on Jul 6, 2021

    @PeterW-gif
    Author

    Sorry just found that although the webpage showed that error, it has downloaded the zip file. I'll try that and get back to you

  7. PeterW-gif commented on Jul 6, 2021

    @PeterW-gif
    Author

    Ok done that and initially no difference but when I did as you asked with the Config Editor and changed that value to false, that appears to have fixed it.

  8. RealRaven2000 commented on Jul 6, 2021

    @RealRaven2000
    Owner

    Ok done that and initially no difference but when I did as you asked with the Config Editor and changed that value to false, that appears to have fixed it.

    Good. To explain, every tab has a specific type and I deliberately hide the toolbar on tabs where it is irrelevant (e.g. calendar, web pages, options etc.) Single message is an edge case but it seems the "current folder bar" is more useful in this case as it gives options for navigating to the next / previous message and even an option to jump out of the folder:
    image

    That's why the toolbar isn't shown in single message by default. The question is how do you use yours? I assume once I am finished with a single message tab I would just close it (or leave it there and click back on the previous [folder] tab if I wanted to leave it there for later...

    . now the question is, do you actually need the toolbar when you are in a single message window? Personally I feel it's only adding clutter .

  9. PeterW-gif commented on Jul 6, 2021

    @PeterW-gif
    Author

    Yes I understand why there would be no point in displaying it in tabs like calendar, but for a mail item in a single tab I find it very useful. The way I work is my email account is a gmail one that I mirror in Thunderbird using IMAP. So when I start TBird it downloads all the latest unread mails. I then click on the first of these to read it and then decide what to do with it which if an important mail that I want to file I then use the envelope handle to drag to its appropriate storage folder in the quickfolders toolbar. I then click next on the main (mail) toolbar to move to the next unread mail and repeat the process. If I hadn't had this facility before and had to do this filing all from the Inbox tab then I suppose I could have got used to doing it that way, but having had it and preferring to file that way, I suddenly missed it when you did that latest update. So I would request that you keep it there, else I presume each time you or Thunderbird update I'll have to go through the Config Editor to get it back.

  10. RealRaven2000 commented on Jul 6, 2021

    @RealRaven2000
    Owner

    ... I suddenly missed it when you did that latest update. So I would request that you keep it there, else I presume each time you or Thunderbird update I'll have to go through the Config Editor to get it back.

    No after I did the patch of 5.6.6pre3 (which honors your setting for extensions.quickfolders.toolbar.hideInSingleMessage ) this will go into the main version. Once you change a setting like this it is stored as "user preference" and won't be overwritten by an Add-on update. The main question is whether I should add a user interface so it can be changed from a checkbox in options.

    I am pretty sure hiding the main QF toolbar on single messages like this has already been in place for a long while, but I could be wrong.

  11. fredstluka commented on Jul 7, 2021

    @fredstluka
  12. crablouis commented on Jul 7, 2021

    @crablouis

    FWIW, I'm running TB 78.11.0 (32-bit) on tehe auto update channel, and QF 5.6.5 of today.

    In this config here, the QF Options setting is persistent. QFToolbar in new message window and/or tab.

    Selecting and de-selecting the options are both persistent and consistently implemented through multiple TB sessions.

  13. PeterW-gif commented on Jul 7, 2021

    @PeterW-gif
    Author

    Firstly to thank RealRavn2000 for his quick attention to this issue and the fix he sent me which he told me will be made permanent.
    Second to confirm that the problem was caused by the latest update to Quick Folders. Having first found it on my Windows 10 64 bit PC I then checked it on my MacBook running OS11. I started Thunderbird, and clicked on a mail to open it in a single tab. At that point the toolbar was displaying. I then opened a fresh tab and checked my add-ons and found that Quick Folders had not yet been updated on the MacBook. So I then updated it and then clicked again on the same single tab email (which had been left open) and now the quick folders toolbar was no longer displayed.
    Thirdly RealRaven asked about "whether I should add a user interface so it can be changed from a checkbox in options". This is already there and works with the fix. Go to Quick Folders Settings, Advanced Tab, and deselect 'Toolbar in Single Message Tabs' and the toolbar disappears, select it again and the toolbar comes back. As far as I can see nothing more needed other than to make the fix permanent.

  14. PeterW-gif commented on Jul 7, 2021

    @PeterW-gif
    Author

    Sorry on that third point, I just noticed it is only the 'Current Folders Toolbar' that toggles with that command, The actual folders bar remains, so yes an extra option to remove that would be required - if anyone really didn't want it to display on single message tabs

  15. RealRaven2000 commented on Jul 7, 2021

    @RealRaven2000
    Owner

    To start with I have changed the setting to default to false (don't hide the toolbar in single message tabs). I had an older setting to hide QF "when not needed" that was long defunct (it is now always doing this) - which prevents the toolbar from being shown in tabs that do not show any mails (calendar, options, Add-ons Manager etc.)

    The setting in config was called extensions.quickfolders.toolbar.onlyShowInMailWindows and there is even a (superflous) UI - a checkbox that doesn't do anything here on the General settings tab:

    image

    So this is where I am going to put a new checkbox for "hiding QuickFolders in single message tabs" instead. I also had to add a new notification event listener so that you can get instant feedback when changing the setting while (a) Thunderbird window(s) is / are open with a single message tab showing. For test version see below:

    QuickFolders-mx-5.6.6pre17.zip

    To install this prerelease version, download the zip file and then drag the zip file into Thunderbird Add-ons Manager.

  16. PeterW-gif commented on Jul 8, 2021

    @PeterW-gif
    Author

    Just downloaded this and yes that seems to do the job, toggling the quickfolders toolbar on and off in the single message tab. It does leave the Current Folder bar displaying but this can also be turned off in the Advanced tab as I outlined above. Many thanks again

  17. RealRaven2000 commented on Jul 12, 2021

    @RealRaven2000
    Owner

    Fixed in Release 5.6.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions