Repository navigation
quickMove - with duplicated folder name, repeat to last folder may end up in wrong path #241
Description
Activity
- Then ... because I found another message that I want to move to the same folder as before ... type "s" (for ME to move mail messages, could be another letter as configured).... That results in showing the SINGLE WORD "alerts" in the recent-folders BOX (the recent-folders BOX does not show anything more than that single word unless you type a down-arrow; then it shows the list of the paths that contain "alerts"). (The bug....) type to move message to that "alerts" folder.
- You may disagree with me, but my expectations is that the word "alerts" in the recent-folder BOX should represent the folder into which I last moved a message. At least that is what I thought for many months. in this case my assumption was that would represent ../../../insurance-one/alerts. However, instead, it represents the FIRST path in the list (i.e. ../../../bank-one/alerts). It moves the message into that FIRST path on the list, rather than the expected path (rather than the folder into which I moved the message the last time).
I agree - the text "alerts" was intended as a placeholder for the last successful quickJump / quickMove operation. I think it might (should?) have been displayed with the parent name as well if it wasn't unique in the original mail move / jump operation. I need to investigate in detail why it doesn't work as intended in your case. May I suggest that we change your complicated title to "quickMove - with duplicated folder name, repeat to last folder may end up in wrong path "
You can check what QuickFolders stores (I think in the case of entering parentname/childname it works) by enabling the debug switch quickMove. Open QuickFolders options, advanced settings and enable debug. Then right-click debug and enable:
extensions.quickfolders.debug.quickMove = truethis will add the detail on what is stored when you enter a new destination to move mails to. It should really store the complete folder path in a second part. The problem is that if you only enter the destination folder name (and no parent) during the search it probably doesn't "know" that this isn't unique and doesn't store more detail.
-
I have turned on
extensions.quickfolders.debug.quickMove = true. But then what? How do I then see the stored information to which you refer? -
...
The problem is that if you only enter the destination folder name (and no parent) during the search it probably doesn't "know" that this isn't unique and doesn't store more detail.
But should it not store the complete path regardless? Not just the part that was last searched?
-
- changed the title
[-]Bug QF 5.8.3 PRO (and back to 5.5.2 PRO): Moving emails by typing to a folder that has similar terminal folder names moves message into wrong folder...[/-][+]quickMove - with duplicated folder name, repeat to last folder may end up in wrong path [/+]on Mar 7, 2022 May I suggest that we change your complicated title to "quickMove - with duplicated folder name, repeat to last folder may end up in wrong path "
I have made the change. You are always welcome to change the "subject" to whatever you feel is most appropriate. I know my terminology may not be correct for the situation.
I finally figured out that the debug information is under TB's Tools _> Developer Tools -> Error Console. I cleared the history and then did a move message (by typing MY "s" followed by "alerts" and selecting a specific path & folder). I am emailing the result directly to you.
In only one place in all the messages is the full path mentioned. Otherwise, all other mentions are of the search string ("alerts").
The problem is that if you only enter the destination folder name (and no parent) during the search it probably doesn't "know" that this isn't unique and doesn't store more detail.
But should it not store the complete path regardless? Not just the part that was last searched?
Yes I think it probably should. Here is the reason why I didn't catch this:
- when you enter a search term and the desired folder is on top of the suggestions, just hitting Enter will select the top item and jump to the folder.
- for this reason (and since I don't like going through long menus with the cursor keys) I had developed a habit of entering the [partial] parent name when I searched for an ambiguous folder name. So in your case I probably would have entered "in/ale" to get the folder "insurance-one/alerts" to show up on top. Once I hit enter, then the (unambiguous) string "insurance-one/alerts" would be stored in the "last successful quickMove" string. I didn't store the complete path because I didn't want a complete path to show up in the search field.
To remedy this problem I obviously need to store both (the text you entered and the full path). But it would still be nice if the algorithm could determine whether the auto-filled name was actually unambiguous and (if not) add the necessary parent folder in the field. This is actually technically difficult as it should only show the minimal amount of parents necessary. So I would also have to think of an algorithm to do this
Let's consider we have 3 folders labelled "alerts":
../../../bank-one/alerts
../../../insurance-one/divisionX/alerts
../../../company-two/divisionX/alertsWhat would be a unique string for the second item? Since both have a direct parent divisionX this is useless as a distinguishing component. Of course one could show "insurance-one/divisionX/alerts" but the path is very log and hard to read.
One way to find he correct path in this example would be by typing "insurance-one>alerts" (or short "in>alerts") so that would be a possibility to store as last successful search. But that would obviously not be unambiguous anymore once we create another folder
../../../insurance-one/divisionA/alerts
In any case, the full path of the last successful quickMove / quickJump operation should be stored. Maybe even the last 5 or 10 if I can think of a simple and useful way of adding them to the menu. The easiest might be using the arrow down key when nothing has been typed yet. This could show the last 10 quickJump locations if you used the shortcut for quickJump and the lat 10 quickMove locations in the case of quickMove. If I implement something like this I will likely create a new github issue to track it.
For the purposes of this issue #241 I will just store the full path of the last operation as you suggested, and store the entered search string (for displaying in the text box) separately.
In any case, the full path of the last successful quickMove / quickJump operation should be stored. Maybe even the last 5 or 10 if I can think of a simple and useful way of adding them to the menu. The easiest might be using the arrow down key when nothing has been typed yet. This could show the last 10 quickJump locations if you used the shortcut for quickJump and the lat 10 quickMove locations in the case of quickMove. If I implement something like this I will likely create a new github issue to track it.
I can appreciate the difficulties involved.
I agree that being able to use the down-arrow key after the initial keystroke (i.e. in my case, "s" for save / quickMove), would be great.
However, since you pointed out to me that (in my case) "s=" starts the quickMove process and then makes visible the recent-list, I can use the down-arrow to select a folder once the recent list is visible and type to quickMove the email message to the selected destination folder.
In my opinion, that method could be enough of a solution. And it also deals with wider range of uses, such a doing quickMove into various different folders (i.e. move to 1, 2, 3, 1, 2, 3, 3, 3, 1, 1, 2, 3, 4, etc.)
However, in order for that to work, the bug discussed in Issue #240 must first be fixed. (The "s = " results in a quickJump instead of a quickMove.)
Can you test this version:
If you hit Enter (only when the menu is NOT shown) then the last location should be selected. Hast to be initialized once (explicit jump into a folder) and then should work forever. If you type the "down" arrow instead it should open the results and Enter would default to the top item in the list instead. If you type anything in the box then the menu will show and Enter always selects the top item, as before.
Now using [QuickFolders-mx-5.9pre33.zip] ... (I never got to pre28 before you made pre33)...
My response on this is slightly 'mixed', but I think we have a winner! Yeah!
On one hand it is now working and putting the moved messages into the intended folder.
On the other hand, I thought at one point (perhaps in the #240 thread?) I thought I understood you to be saying that you would (or might), when doing a repeated quickMove, make the information in the search box say more of the path, not just the terminal folder name (when the original search typing by the user was only the terminal folder name).
So, using our previous examples, the search box still says "alerts" under version 5.9pre33.
However, it does correctly quickMove into the last-moved-into folder and not just (potentially incorrectly) into the top folder in the list.
Whether or not you want more of the path name visible in the search box is above my pay grade. It IS working well for me now -- the quickMove is moving emails to the expected folder.
(If it is important to the particular user to see the other folders in the search result list for "alerts", the user CAN down-arrow and then the list becomes visible and the user, can, if the users wishes to do so, select any folder in that list for quickMove into.)
Thank you for your excellent dedication to this work.
I came here searching as I also have same folder names in differently named subfolders and subsequent go/save/copy just selects the first in the list.
I tried QuickFolders-mx-5.9pre33.zip and it works wonderfully, nice to see such commitment and professionalism yet again @RealRaven2000 , and great job reporting and working on it @jaysmithgit .
I came here searching as I also have same folder names in differently named subfolders and subsequent go/save/copy just selects the first in the list. I tried QuickFolders-mx-5.9pre33.zip and it works wonderfully, nice to see such commitment and professionalism yet again @RealRaven2000 , and great job reporting and working on it @jaysmithgit .
Thanks @fanis -- I am just an "ordinary" user, but I believe in doing all I can to assist developers in improving their products. Too many people in our world just assume "somebody else will report it or fix it." I am glad that my efforts helped to solve the same problem you were having. The developer of QF is both very talented and very dedicated -- it is a pleasure to use such a useful add-on.
Fixed in 5.9, released on 30/03/2022
I have confirmed that the 5.5.2 PRO bug I found today also exists in 5.8.3 PRO. (I have upgraded to 5.8.3. I am on TB 78.7.1.)
This is a little complicated. Please bear with me.
This bug apparently can only exist in Pro because only in Pro it is possible to move messages by starting with a keystroke.
I have assigned "s" (save) for my use, but I think the default may be "m". I mention this in case the bug is related to me not using the original default keystroke for this function.
I am able to repeat this problem.
Necessary folders environment to have this problem: Two or more folders with the same TERMINAL folder name, such as "alerts"...
../../../bank-one/alerts
../../../insurance-one/alerts
../../../company-two/alerts
...... etc.
First, type "s" (for ME to move mail messages, could be another letter as configured), followed by "alerts". That results in showing a folder list showing the folder paths I have listed above. Then use the keyboard down-arrow key to navigate to the SECOND OR FURTHER folder (NOT the first one -- the first one does not have a bug). Type to move message to that folder: ../../../insurance-one/alerts
Then ... because I found another message that I want to move to the same folder as before ... type "s" (for ME to move mail messages, could be another letter as configured).... That results in showing the SINGLE WORD "alerts" in the recent-folders BOX (the recent-folders BOX does not show anything more than that single word unless you type a down-arrow; then it shows the list of the paths that contain "alerts"). (The bug....) type to move message to that "alerts" folder.
You may disagree with me, but my expectations is that the word "alerts" in the recent-folder BOX should represent the folder into which I last moved a message. At least that is what I thought for many months. in this case my assumption was that would represent ../../../insurance-one/alerts. However, instead, it represents the FIRST path in the list (i.e. ../../../bank-one/alerts). It moves the message into that FIRST path on the list, rather than the expected path (rather than the folder into which I moved the message the last time).
Back on 5.5.2, it was NOT possible to down-arrow in step 7. However, in 5.8.3 (or sometime since 5.5.2) it is now possible to down-arrow in step 7 (I think this corrected a bug report I filed). Thus the user can in 5.8.3 down arrow to the correct full path. But... if the user has assumed that "alerts" represents the folder that they moved messages to last time, they will be severely disappointed to eventually discover their messages are in folders other than what they expected. (Today I discovered several hundred such incorrectly filed messages, but it was easy to clean up.)
So, in 5.8.3 by using down-arrow, there is no problem. However, if the user just sees "alerts" and assumes that it is the desired "alerts" folder, and types , there is a problem.
I hope this makes sense.