Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font color in striped mode ignored on colored tabs #7

Closed
RealRaven2000 opened this issue Oct 7, 2019 · 6 comments
Closed

font color in striped mode ignored on colored tabs #7

RealRaven2000 opened this issue Oct 7, 2019 · 6 comments
Assignees

Comments

@RealRaven2000
Copy link
Owner

When a font color is defined in "striped mode" this is not used on tabs that have a colored striped on top.

@RealRaven2000 RealRaven2000 self-assigned this Oct 7, 2019
@RealRaven2000
Copy link
Owner Author

This appears to be caused by a syntax error using the :not pseudo selector in quickfolders-interface.js, line 6309:

  engine.setElementStyle(ss, '.quickfolders-flat toolbarbutton:not[#QuickFoldersCurrentFolder]' + coloredPaletteClass + ' > label','color', inactiveColor, false);
  engine.setElementStyle(ss, '.quickfolders-flat toolbarbutton:not[#QuickFoldersCurrentFolder]' + paletteClass + ' > label','color', inactiveColor, false);

@RealRaven2000
Copy link
Owner Author

Here is a tryout version (4.17 prerelease 25) with the bugfix:

QuickFolders-wx-4.17pre25.zip

@crti
Copy link

crti commented Nov 6, 2019

Not sure if the usage of DarkMode Theme and this white on bright tabs is related to the issue:
QuickFolders-DarkMode

@RealRaven2000
Copy link
Owner Author

Did you try pre25 ? Also are you using Flat Style +Striped? Can't really see any "stripe" colors on your screenshot... maybe a screenshot of your QuickFolders "Layout / Bling my tabs" settings (third tab, after Advanced) would be helpful.

@crti
Copy link

crti commented Nov 9, 2019

Thx for the hint. Sorry for not trying myself in the QF settings. I'm now on Apple Pills which I like the most so far.

@RealRaven2000
Copy link
Owner Author

Fixed in 4.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants