Recent Folder does not update until TB closed and reopened

[swolh]

The drop down list of recently opened folders that shows up when you click on the "Recent Folders" tab does not update after you've opened or moved a message to a folder. It seems to only update by closing TB and reopening TB.

[RealRaven2000]

The drop down list of recently opened folders that shows up when you click on the "Recent Folders" tab does not update after you've opened or moved a message to a folder. It seems to only update by closing TB and reopening TB.

OK, I immediately ran a test with the debug option
extensions.quickfolders.debug.recentFolders = true

and getting the following output when clicking the recent folders tag / button:

QuickFolders {RECENTFOLDERS} 21:52:17.705  [38329 ms]	 
createRecentTab(  passedPopup: null, isDrag: false, passedButton: QuickFolders-Recent-CurrentFolderTool)
QuickFolders {RECENTFOLDERS} 21:52:17.705  [0 ms]	 
createRecentPopup(passedPopup:null, isDrag:false, isCreate:false)
QuickFolders {RECENTFOLDERS} 21:52:17.705  [0 ms]	 
Creating Popup Set for Recent Folders tab
QuickFolders {RECENTFOLDERS} 21:52:17.705  [0 ms]	 
generateMRUlist()
QuickFolders {RECENTFOLDERS} 21:52:17.718  [13 ms]	 
=============================
createRecentPopup Finished!

The code that is supposed to rebuild the most recent list is in generateMRUlist(), so I will debug that one in detail to see what the heck is happening... For now I am flagging this one as Tb78 regression, let's see what happens...

[swolh]

Thank you

------ Original Message ------ Subject: Re: [RealRaven2000/QuickFolders] Recent Folder does not update until TB closed and reopened (#76) Date: Mon, 23 Nov 2020 13:54:14 -0800 To: Realraven2000/quickfolders <QuickFolders@noreply.github.com>, Steven <swolh@comcast.net>, Author <author@noreply.github.com>

From: Realraven2000 ***@***.***> The drop down list of recently opened folders that shows up when you click on the "Recent Folders" tab does not update after you've opened or moved a message to a folder. It seems to only update by closing TB and reopening TB. OK, I immediately ran a test with the debug option |extensions.quickfolders.debug.recentFolders = true| and getting the following output when clicking the recent folders tag / button: |QuickFolders {RECENTFOLDERS} 21:52:17.705 [38329 ms] createRecentTab( passedPopup: null, isDrag: false, passedButton: QuickFolders-Recent-CurrentFolderTool) QuickFolders {RECENTFOLDERS} 21:52:17.705 [0 ms] createRecentPopup(passedPopup:null, isDrag:false, isCreate:false) QuickFolders {RECENTFOLDERS} 21:52:17.705 [0 ms] Creating Popup Set for Recent Folders tab QuickFolders {RECENTFOLDERS} 21:52:17.705 [0 ms] generateMRUlist() QuickFolders {RECENTFOLDERS} 21:52:17.718 [13 ms] ============================= createRecentPopup Finished! | The code that is supposed to rebuild the most recent list is in |generateMRUlist()|, so I will debug that one in detail to see what the heck is happening... For now I am flagging this one as Tb78 regression, let's see what happens... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARST5ZEWWRCBXPG57Z27H73SRLKYNANCNFSM4T72EYCA>.

Steven Wolhandler, JD, MA, LPC Author of Protecting Yourself from Emotional Predators <https://www.amazon.com/Protecting-Yourself-Emotional-Predators-Manipulators/dp/0692160523/> “A problem properly understood is a problem that can be solved.” Mediation, Arbitration, Custody Evaluations, PC/DM, Advice about Abusive People 720 270-0070 http://www.creativeresolutions.org/ <http://www.creativeresolutions.org/> and https://emotionalpredators.com/ <https://emotionalpredators.com/>

[RealRaven2000]

Thank you

be careful if you reply to github issues via email - the complete text gets listed online - you may want to shorten it or answer directly on github - I can do it for you too if it's ok with you? I found the list is generated correctly but the old menupopup is not removed (in the original implementation it was the first child element of the button, so I guess we have duplicate menus and only the first one (outdated!) is being shown:

Should be relatively easy to fix, but a concern if I may have used the pattern (remove buttonElement.firstChild to get rid of an old popup) elsewhere.

[RealRaven2000]

...and here is a test version with a quick fix:

QuickFolders-wx-5.1pre2.zip

(download an drag to Thunderbird Add-ons manager to test - no restart necessary)

[RealRaven2000]

fixed in 5.1 released on 10/Dec/2020