Current Folder Toolbar display - text is always black #81
Comments
|
I did some testing with dark themes on Tb68 vs 78. apparently the selector for the button is not specific enough. Please try out this version:
To install, download the zip file and then drag into Add-ons Manager! |
|
I added an additional selector for label and icon on the "hovered" state, as well: Uploading QuickFolders-wx-5.1pre10.zip… To install, download the zip file and then drag into Add-ons Manager! |
RealRaven2000
changed the title
RealRaven2000
changed the title
|
Just tested 5.1pre24. I am also running into a problem installing the version which seems to be Thunderbird-related and I had to copy the 'chrome' folder and others manually. More about that below. |
I can't reproduce this [coloring works always even if tabs of the current folder exist] - did you restart Thunderbird just in case old CSS rules were "hanging around"? What color settings have you set for "Uncolored tabs" - it would be best if you could post a screenshot of your color settings (bling my tabs) in the QuickFolders options dialog. As example, here are my settings for testing with a dark theme: please leave ths issue open until I officially release 5.1 on atn. |
|
|
|
I just tried your color settings on my system still can't reproduce - I believe it may be theme colors specific to your Operating System - which one are you on? You could inspect the current folder element via tools / developer tools / developer toolbox and the inspector: once you activate the element picker, click on the current folder panel: Expand the on the right hand side select "Computed" (Styles) and expand the you should see the "winning" rule / selector on top. just paste a screenshot of this set of rules and we can go forward. It is interesting to know the exact selector with the black color, the css file name and line number. PS I forgot - if you can't find the rule that causes the dark text color, it may help to see the "full picture" if you activate the [x] Browser Styles checkbox on the top right:
this will include all "ground-rules" from Thunderbird. |
|
Hi,
I am running Windows 10 20H2 with all the most recent updates 19042.662.
To perform the testing I removed all extensions except QuickFolders to make sure they do not interfere. Especially, the DeepDark extension that uses specific files in a chrome directory.
The installation of 5.1pre24 went fine.
I first tested the Current Folder Toolbar for a folder which does not have a tab
Then I did the same thing with a folder that has a tab
I find the toolbarbutton-text entry for 'Atlantico' twice :
Regards,
Maurice
Le 02/12/2020 à 15:30, RealRaven2000 a
écrit :
… I just tried your color settings on my system still can't reproduce - I believe it may be theme colors specific to your Operating System - which one are you on? You could inspect the current folder element via tools / developer tools / developer toolbox and the inspector:
once you activate the element picker, click on the current folder panel:
Expand the toolbarbutton element in the left hand pane and click on label:
on the right hand side select "Computed" (Styles) and expand the color rule:
you should see the "winning" rule / selector on top. just paste a screenshot of this set of rules and we can go forward. It is interesting to know the exact selector with the black color, the css file name and line number.
|
|
Here are the steps I performed.
|
If you want to send screenshot, please do it from github directly. Directly replied mails are very hard to read. (I edited your first post to make it a little easier, but screens were missing) |
|
If this image is your "Computed styles":
.. you may have to expand the first two lines so the full rule is shown. We need to find out which rule has higher specificity and why. |
|
It is indeed my "Computed styles". What do I expand exactly ?
Le 05/12/2020 à 14:45, RealRaven2000 a
écrit :
If this image is your "Computed styles":
https://user-images.githubusercontent.com/45902444/101244242-8b844e00-3705-11eb-9c27-a6bbd7f22368.jpg
.. you may have to expand them so the full rule is shown.
—
You are receiving this because you modified the open/close
state.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
|
|
I have taken out the named rule for now - even though it is inherited from the parent element (the button) it may give problems because of higher specificity - see: New version below: I am hoping the missing colors on that element won't matter, but we will see. I can add a class-based rule later. Installation: download the zip file above. Then drag the file into Thunderbird Add-ons Manager. |
|
Version 5.1pre35 does fix the issue.
The chart to illustrate the concept of specificity is interesting and funny. I am afraid it is a bit beyond my grasp but I get the
general idea.
Would like me to provide some more debugging information ?
Many thanks for your help.
Regards,
Maurice
|
No, it's fine. I had to do a few more changes for dark mode to make the standard button (uncolored) text and icons color work. Installation: download the zip file above. Then drag the file into Thunderbird Add-ons Manager. PS: Remember if you reply vie email, just cut out all the quoted text at the bottom because otherwise I have edit all your posts which is extra work. I would prefer if you could go to github directly (you can even paste screenshots here) but it's ok if you can't do that. |
|
I have installed 5.1pre42 and performed a number of tests. |
|
fixed in release 5.1 on 10/Dec/2020 |
Hi,
I am currently using Thunderbird 78.5.0 and QuickFolders Pro 5.0.
In the main toolbar, the font used to display the tab varies depending on the tab colour (e.g. White for dark blue, black for yellow).
The same does not apply to the Current Folder toolbar. The tab name is always in black, making it difficult to read in some cases.
Regards,
MP
The text was updated successfully, but these errors were encountered: