Current Folder Toolbar display - text is always black

[Vacoas]

Hi,
I am currently using Thunderbird 78.5.0 and QuickFolders Pro 5.0.
In the main toolbar, the font used to display the tab varies depending on the tab colour (e.g. White for dark blue, black for yellow).

The same does not apply to the Current Folder toolbar. The tab name is always in black, making it difficult to read in some cases.

Regards,
MP

[RealRaven2000]

I did some testing with dark themes on Tb68 vs 78. apparently the selector for the button is not specific enough. Please try out this version:

QuickFolders-wx-5.1pre9.zip

• I also added a rule for the (svg - based) icon color to harmonise with the selected text for "uncolored" tabs.
• I think I may need to modify the rules for hovered colors as well to make them "override" the default color when you hold the mouse pointer over an uncolored tab.

To install, download the zip file and then drag into Add-ons Manager!

[RealRaven2000]

I added an additional selector for label and icon on the "hovered" state, as well:

Uploading QuickFolders-wx-5.1pre10.zip…

To install, download the zip file and then drag into Add-ons Manager!

[Vacoas]

Just tested 5.1pre24.
Folders for which there is NO tab are displayed correctly in the current folder toolbar :

Folders for which there IS a tab are not correctly displayed :

I am also running into a problem installing the version which seems to be Thunderbird-related and I had to copy the 'chrome' folder and others manually. More about that below.

[RealRaven2000]

Just tested 5.1pre24.
Folders for which there IS a tab are not correctly displayed :

I can't reproduce this [coloring works always even if tabs of the current folder exist] - did you restart Thunderbird just in case old CSS rules were "hanging around"? What color settings have you set for "Uncolored tabs" - it would be best if you could post a screenshot of your color settings (bling my tabs) in the QuickFolders options dialog.

As example, here are my settings for testing with a dark theme:

please leave ths issue open until I officially release 5.1 on atn.

[Vacoas]

I did restart Thunderbird every time I loaded something new.

[RealRaven2000]

I just tried your color settings on my system still can't reproduce - I believe it may be theme colors specific to your Operating System - which one are you on?

You could inspect the current folder element via tools / developer tools / developer toolbox and the inspector:

once you activate the element picker, click on the current folder panel:

Expand the toolbarbutton element in the left hand pane and click on label:

on the right hand side select "Computed" (Styles) and expand the color rule:

you should see the "winning" rule / selector on top. just paste a screenshot of this set of rules and we can go forward. It is interesting to know the exact selector with the black color, the css file name and line number.

PS I forgot - if you can't find the rule that causes the dark text color, it may help to see the "full picture" if you activate the [x] Browser Styles checkbox on the top right:

this will include all "ground-rules" from Thunderbird.

[Vacoas]

Hi, I am running Windows 10 20H2 with all the most recent updates 19042.662. To perform the testing I removed all extensions except QuickFolders to make sure they do not interfere. Especially, the DeepDark extension that uses specific files in a chrome directory. The installation of 5.1pre24 went fine. I first tested the Current Folder Toolbar for a folder which does not have a tab Then I did the same thing with a folder that has a tab I find the toolbarbutton-text entry for 'Atlantico' twice : Regards, Maurice Le 02/12/2020 à 15:30, RealRaven2000 a écrit :

…

I just tried your color settings on my system still can't reproduce - I believe it may be theme colors specific to your Operating System - which one are you on? You could inspect the current folder element via tools / developer tools / developer toolbox and the inspector: once you activate the element picker, click on the current folder panel: Expand the toolbarbutton element in the left hand pane and click on label: on the right hand side select "Computed" (Styles) and expand the color rule: you should see the "winning" rule / selector on top. just paste a screenshot of this set of rules and we can go forward. It is interesting to know the exact selector with the black color, the css file name and line number.

[Vacoas]

Here are the steps I performed.
Starting Thunderbird with a current folder such as 'Contrepoints'.
Selecting 'Figaro' in the folder pane.
This seems to generate two actions as I have 2 entries for 'toolbarbutton-text' and 'Figaro'.
The first entry has the right color for the text: rgb(220,235,245).
The second entry comes back with rgb(0,0,0) which seems to overwrite the previous entry.

[RealRaven2000]

Hi, I am running Windows 10 20H2 with all the most recent updates 19042.662. To perform the testing I removed all extensions except QuickFolders to make sure they do not interfere. Especially, the DeepDark extension that uses specific files in a chrome directory. The installation of 5.1pre24 went fine. I first tested the Current Folder Toolbar for a folder which does not have a tab Then I did the same thing with a folder that has a tab I find the toolbarbutton-text entry for 'Atlantico' twice : Regards, Maurice Le 02/12/2020 à 15:30, RealRaven2000 a écrit :
…
I just tried your color settings on my system still can't reproduce - I believe it may be theme colors specific to your Operating System - which one are you on? You could inspect the current folder element via tools / developer tools / developer toolbox and the inspector: once you activate the element picker, click on the current folder panel: Expand the toolbarbutton element in the left hand pane and click on label: on the right hand side select "Computed" (Styles) and expand the color rule: you should see the "winning" rule / selector on top. just paste a screenshot of this set of rules and we can go forward. It is interesting to know the exact selector with the black color, the css file name and line number.

If you want to send screenshot, please do it from github directly. Directly replied mails are very hard to read. (I edited your first post to make it a little easier, but screens were missing)

[RealRaven2000]

If this image is your "Computed styles":

.. you may have to expand the first two lines so the full rule is shown. We need to find out which rule has higher specificity and why.