Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag email icon in Navigation (Current Folder) bar to a folder / QuickFolder drop target #84

Closed
PeterW-gif opened this issue Dec 4, 2020 · 8 comments

Comments

@PeterW-gif
Copy link

TB 78.5.1 quickfolders V5.0 In email display tab the feature to drag the 'current email to a Quickfolders tab; doesn't work now (used to under previous version)
The hand icon shows when the cursor is placed on the mail 'envelope' icon and changed to grabbed when clicked but the mail doesn't move when dragged to any folder in the folders tab toolbar
This under Windows 7 but also the same on my Macbook under OS 11

@RealRaven2000 RealRaven2000 self-assigned this Dec 4, 2020
@RealRaven2000 RealRaven2000 pinned this issue Dec 4, 2020
@RealRaven2000 RealRaven2000 changed the title Can't drag email to a folder Can't drag email icon in Navigation (Current Folder) bar to a folder / QuickFolder drop target Dec 4, 2020
@PeterW-gif
Copy link
Author

Quite right - that's what I meant - glad to see it wasn't just something I was doing wrong

@RealRaven2000
Copy link
Owner

Quite right - that's what I meant - glad to see it wasn't just something I was doing wrong

The good news is I get an exception in Javascript error console when I start to drag, so that's an easy enough pointer for the rewrite:

Uncaught ReferenceError: TransferData is not defined
    msgObs_startDrag chrome://quickfolders/content/quickfolders.js:1468
    ondragstart chrome://messenger/content/messenger.xhtml:1

@RealRaven2000
Copy link
Owner

..the fix was relatively trivial, but I noticed another problem - when multiple emails are selected (e.g. a whole thread) the Navigation Bar (a.k.a. Current Folder Bar) is hidden. That's makes it not useful, I really want to be able to select a bunch of mails and then drag the mail envelope. It means I probably need to move the current folder bar to a different container in the main document.

Fixed version, so far:

QuickFolders-wx-5.1pre29.zip

@RealRaven2000
Copy link
Owner

when multiple emails are selected (e.g. a whole thread) the Navigation Bar (a.k.a. Current Folder Bar) is hidden. That's makes it not useful, I really want to be able to select a bunch of mails and then drag the mail envelope. It means I probably need to move the current folder bar to a different container in the main document.

Fixed that one, too:
QuickFolders-wx-5.1pre30.zip

@PeterW-gif
Copy link
Author

Sorry, just downloaded that zip file but could not find any .xpi file inside

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Dec 5, 2020

Sorry, just downloaded that zip file but could not find any .xpi file inside

You can drag the zip file directly into Add-ons Manager. github doesn't allow uploading of xpi files in comments, although internally they are the same.

@PeterW-gif
Copy link
Author

Sorry didn't know that, just done it and your fix works - many thanks

@RealRaven2000
Copy link
Owner

fixed in release 5.1 on 10/Dec/2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants