Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartTemplate 2.1 problems with determining current language of Thunderbird #4

Closed
RealRaven2000 opened this issue Aug 6, 2019 · 2 comments
Assignees

Comments

@RealRaven2000
Copy link
Owner

@RealRaven2000 RealRaven2000 commented Aug 6, 2019

This is probably related to issue #3 - this can be seen in the error console as:
getLocale() returns: undefined

the function getLocalePref()_ used to call nsILocaleService.getAppLocaleAsLangTag() which is deprecated. It was changed to nsILocaleService.requestedLocale which is wrong and should be locale.getRequestedLocale().

Also matching the requested locale (e.g. "de-DE") may not correctly match with the identifiers of the languages supported by SmartTemplate (e.g. "de"). The matching algorithm needs to be improved.

@RealRaven2000 RealRaven2000 self-assigned this Aug 10, 2019
@RealRaven2000

This comment has been minimized.

Copy link
Owner Author

@RealRaven2000 RealRaven2000 commented Aug 10, 2019

Planned fixes for 2.2
try to match flavors "en" when installed language is "en-GB". Display correct error information for the different cases

  1. Needing a language Pack (needed for %datelocal% and %dateshort%)
  2. Needing native support from SmartTemplate⁴ (for %A% %a% %B% %b%) - currently SmartTemplate⁴ supports 20 languages

Depending on what was used these problems will be logged in JavaScript error console. I felt the error dialog was too disruptive.

@RealRaven2000

This comment has been minimized.

Copy link
Owner Author

@RealRaven2000 RealRaven2000 commented Aug 11, 2019

Resolved with Release 2.2 - just submitted to ATN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.