Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SmartTemplates compatible with Thunderbird 91 - ESR 2021/2022 #127

Closed
RealRaven2000 opened this issue Mar 5, 2021 · 6 comments
Closed
Assignees

Comments

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Mar 5, 2021

SmartTemplates doesn't work well with the latest Beta of Thunderbird 87.

  • nsIAbManager.directories has been converted from nsIMutable array to Array, which will cause addressbook lookups to break the templates loader.

Here is a first fixed version. please append more defects for beta versions below:

smartTemplate-fx-3.5pre16.zip

@RealRaven2000 RealRaven2000 changed the title Make SmartTemplates compatible with Thunderbird 87.0b1 Make SmartTemplates compatible with Thunderbird 89.* / 91.* - ESR 2022 May 18, 2021
@RealRaven2000
Copy link
Owner Author

Current prerelease version:
smartTemplate-fx-3.5pre196.zip

Work done so far:
Using new background script notification mechanism for all template menus. When configuring the menus, these are now updated properly across all windows once the settings dialog is closed. Even with multiple Thunderbird windows opened.

To do:
I have done a lot of fundamental work on[mx l10n] (localization to be compatible with web extensions), only open point at the moment is that I still use the old properties format through the stringBundle service for explicit date format (where the user gets to choose the locale) - I have to ask @tbsync on whether this will be possible with a future l10n script patch.
On the Add-on dev call I got some additional suggestions , Phillipe mentioned I could pull these from lightning (but I don't know whether this will include all locales), Arnd suggested to use an additional sub-function of Intl.DateTimeFormat which may however change behavior after Thunderbird 80.

Intl.DateTimeFormat().formatXXX

@RealRaven2000
Copy link
Owner Author

Here is the latest version.

  • Fixing some problems with switching between identities that may lead to the template not being executed (or duplicated)
  • account iterator changed in Tb91 which impacted license validation
  • Fixed bug in accounts API during folder traversing
  • Fixed tidying up listeners on shutdown / update of the Add-on

smartTemplate-fx-3.7pre16.zip

To install, download zip file and then drag into Thunderbird Add-ons Manager.

@RealRaven2000
Copy link
Owner Author

Another problem I found in Tb92 - the Examples tab does not load any content.

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Aug 3, 2021

This version fixes the following problems:

  • fixed the "Buy License" button at the bottom of settings window
  • wrong icons sliding notifications a
  • no sliding notifications (but fallback messageboxes) shown in Composer
  • fixed all about:config dialogs which show selected preferences (e.g. right-clicking the debug checkbox)

smartTemplate-fx-3.7pre24.zip

To install, download zip file and then drag into Thunderbird Add-ons Manager.

@RealRaven2000 RealRaven2000 self-assigned this Aug 14, 2021
@RealRaven2000 RealRaven2000 changed the title Make SmartTemplates compatible with Thunderbird 89.* / 91.* - ESR 2022 Make SmartTemplates compatible with Thunderbird 91 - ESR 2021/2022 Aug 14, 2021
@RealRaven2000 RealRaven2000 pinned this issue Aug 14, 2021
@RealRaven2000
Copy link
Owner Author

Latest version. includes the new %clipboard% variable suggested in #118:

smartTemplate-fx-3.7pre35.zip

To install, download zip file and then drag into Thunderbird Add-ons Manager.

@RealRaven2000
Copy link
Owner Author

Complete in 3.7 released on 20/08/2021

@RealRaven2000 RealRaven2000 unpinned this issue Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant