Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Files - Toolbar buttons missing #143

Closed
jonaskohl opened this issue Aug 11, 2021 · 6 comments
Closed

Template Files - Toolbar buttons missing #143

jonaskohl opened this issue Aug 11, 2021 · 6 comments
Labels

Comments

@jonaskohl
Copy link

When trying to add a template file, the toolbar buttons for adding, removing or moving a template file are missing. (See attached screenshot)
Screenshot 2021-08-11 140749

@RealRaven2000
Copy link
Owner

OK, looks weird - what version of Thunderbird and SmartTemplates are you using? What OS?
What happens if you try to increase the window height by dragging down on the bottom right corner?

@jonaskohl
Copy link
Author

I'm using Thunderbird 78.13.0 on Windows 10 2004 and SmartTemplates 3.6.

It looks the same when dragging down the window.

Screenshot 2021-08-11 171955

After a bit of digging with the DevTools, I found this CSS rule (added at xul.css:54 by ThunderBird apparently):

*|*:root[chromehidden~="menubar"] .chromeclass-menubar, *|*:root[chromehidden~="directories"] .chromeclass-directories, *|*:root[chromehidden~="status"] .chromeclass-status, *|*:root[chromehidden~="extrachrome"] .chromeclass-extrachrome, *|*:root[chromehidden~="location"] .chromeclass-location, *|*:root[chromehidden~="location"][chromehidden~="toolbar"] .chromeclass-toolbar, *|*:root[chromehidden~="toolbar"] .chromeclass-toolbar-additional {
    display: none;
}

So after adding this CSS rule:

.templateList > toolbarbutton {
    display: inline;
}

the buttons once again display as normal.

Screenshot 2021-08-11 172517

So I think this has to be added to the add-on's CSS file for it to fix it.

@RealRaven2000
Copy link
Owner

So I haven'#t see this rule here on Windows 7; I would believe it is this part
|:root[chromehidden~="toolbar"] .chromeclass-toolbar-additional {
display: none;
}

as the buttons have the class "chromeclass-toolbar-additional". I wonder if this is specific to Windows 10, that would be a bad bug.

@RealRaven2000
Copy link
Owner

I also tested on my recording PC / DAW which is win10 64bit but the toolbar was visible. Probably no harm in adding the rule anyway. The display value for the buttons here reads as "-moz-box"...

@RealRaven2000
Copy link
Owner

I added

#fileTemplateToolbar.templateList > toolbarbutton.chromeclass-toolbar-additional {
  display: inline-block;
}

I wasn't quite sure whether the descendant selector added enough specificity. Can you check this version?

smartTemplate-fx-3.7pre25.zip

(drag into Add-ons manager after downloading, no need to unpack)

@RealRaven2000
Copy link
Owner

Fixed in 3.7 published 20/08/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants