Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve *selection* placeholder in Snippets to better support non-text nodes #182

Closed
RealRaven2000 opened this issue May 1, 2022 · 1 comment
Assignees

Comments

@RealRaven2000
Copy link
Owner

The placeholder selection can be used to add HTML to existing selected material in an email. When the selection goes across different content this can be erratic (it only really works with text only in its current forms).

Ideally I want to be able to highlight a non-text HTML object and "decorate" it with some "outer HTML". For example, I have the following snippet, which I want to use to add a border and shadow to a selected image:

<div style="border: 1px solid rgba(80, 80, 80, 0.3); box-shadow: rgba(80, 80, 80, 0.3) 5px 5px 5px; width:max-content;">
*selection*
</div>

note: I added line breaks for readability

In the current version this will wrap the containing element (paragraph) which is not intended. Expected behavior: if an image is selected just insert the image into the <div> element.

@RealRaven2000
Copy link
Owner Author

Implemented in 3.12.1 on 28/06/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant