Skip to content

4.0b3 regression - composer: open snippet / change template from file directly inserts nothing #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RealRaven2000 opened this issue Jul 19, 2023 · 4 comments
Assignees
Labels
bug ESR 115 Changes for Thunderbird SuperNova UI

Comments

@RealRaven2000
Copy link
Owner

Inserting a fragment via "Open SmartTemplates template file..." directly is broken. It work when using a template from an existing menu item.

image

@RealRaven2000 RealRaven2000 added bug ESR 115 Changes for Thunderbird SuperNova UI labels Jul 19, 2023
@RealRaven2000 RealRaven2000 self-assigned this Jul 19, 2023
@RealRaven2000 RealRaven2000 changed the title 4.0b3 regression - opening 4.0b3 regression - opening snippet from file directly inserts nothing Jul 19, 2023
@RealRaven2000 RealRaven2000 changed the title 4.0b3 regression - opening snippet from file directly inserts nothing 4.0b3 regression - composer: open snippet / change template from file directly inserts nothing Jul 19, 2023
@RealRaven2000
Copy link
Owner Author

The bug also applies to "change template / Open SmartTemplates template file..."

image

@RealRaven2000 RealRaven2000 pinned this issue Jul 19, 2023
@RealRaven2000
Copy link
Owner Author

I did a few things. I think this should kind of fix the issue:

smartTemplate-fx-4.0pre292.zip

  • the fields aren't interactive though, so not sure if there is more to do here. You can definitely use it to change the template or insert some HTML code "ad hoc" by selecting the template from disk.

@RealRaven2000
Copy link
Owner Author

Fixed more issues, such as the "last template" not updating correctly (or even being removed).

  • when selecting "Open smartTemplates file..." from any of the reply / forward / write menus this will now be remembered as "Last template":
    image

  • when using the "Change Template..." menu in composer, the template will also be remembered as the last template (for the appropiate compose type of write, reply or forward).
    image

All menus are updated immediately through all Thunderbird windows / tabs.

smartTemplate-fx-4.0pre303.zip

To install, download the zip file above, then drag it into Thunderbird Add-ons Manager. (Don't extract contents)

RealRaven2000 added a commit that referenced this issue Jul 22, 2023
@RealRaven2000 RealRaven2000 unpinned this issue Aug 9, 2023
@RealRaven2000
Copy link
Owner Author

Fixed in 4.0.2 - Published 26/07/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ESR 115 Changes for Thunderbird SuperNova UI
Projects
None yet
Development

No branches or pull requests

1 participant