Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run filters on folder button doesn't run filters #1

Closed
RealRaven2000 opened this issue Sep 5, 2019 · 2 comments
Closed

Run filters on folder button doesn't run filters #1

RealRaven2000 opened this issue Sep 5, 2019 · 2 comments
Labels

Comments

@RealRaven2000
Copy link
Owner

"I have found that recently in ver 4.1, the run filters on folder Icon/ button has stop working. Menu - Tools, Run filters on folder works."

@RealRaven2000
Copy link
Owner Author

This regression is caused by some code I wrote for Thunderbird 68 - code:

  if (util.versionGreaterOrEqual(util.AppverFull, "67")) {
    var {MailServices} = ChromeUtils.import("resource:///modules/MailServices.jsm"); // new module spelling
  }
  else 
    Components.utils.import("resource:///modules/mailServices.js", {});

the last line will import the Symbol as "mailServices" and not "MailServices"

Fix is to force the new variable name in both cases:

  var {MailServices} = 
    (util.versionGreaterOrEqual(util.AppverFull, "64")) ?
      ChromeUtils.import("resource:///modules/MailServices.jsm") : // new module spelling
      Components.utils.import("resource:///modules/mailServices.js", {});

@RealRaven2000
Copy link
Owner Author

Fixed in version 4.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant