Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply-to cannot be edited #107

Closed
RealRaven2000 opened this issue Jun 1, 2022 · 6 comments
Closed

Reply-to cannot be edited #107

RealRaven2000 opened this issue Jun 1, 2022 · 6 comments
Assignees

Comments

@RealRaven2000
Copy link
Owner

When we use the "reply-to" filter option, it adds the choice "Reply-To" (capitalized first letters) as a search term, however this term cannot be edited anymore, and no visible value is added by the assistant:

image

There should be a text edit field to the right. Adding "reply-to" (all lowercase) as a custom field works, but it is not autofilled by the assistant.

@RealRaven2000 RealRaven2000 self-assigned this Jun 1, 2022
@RealRaven2000
Copy link
Owner Author

According to my tests this works in Thunderbird 68 but not 91 / 101. Guess it is a regression from Thunderbird 91.

@RealRaven2000
Copy link
Owner Author

In error console (both in Tb91 and TB101 when I select the "Reply-To" item) the following error is recorded:

Error: not well-formed XML
    parseXULToFragment chrome://global/content/customElements.js:566
    patchCustomTextbox chrome://quickfilters/content/qFilters-filterEditor.js:387
    callbackCustomSearchCondition chrome://quickfilters/content/qFilters-filterEditor.js:458
    callbackCustomSearchCondition chrome://quickfilters/content/qFilters-filterEditor.js:407
    buildFilter chrome://quickfilters/content/qFilters-worker.js:1465
    createFilter chrome://quickfilters/content/qFilters-worker.js:783
    createFilterAsync_New chrome://quickfilters/content/qFilters-worker.js:1583
XML Parsing Error: not well-formed
Location: moz-nullprincipal:{bb69a86f-c2b7-4148-acc0-e6c9b89123af}
Line Number 6, Column 51:

@RealRaven2000
Copy link
Owner Author

Here is a fixed version:

quickFilters-wx-5.5.2pre4.zip

This works in Thunderbird 91, but there is still a bigger issue in Thunderbird 101.b4 in that the line:

messenger.WindowListener.registerWindow("chrome://messenger/content/FilterEditor.xhtml", 
  "chrome/content/scripts/qFi-filterEditor.js");

is loaded too late, so that the custom search terms cannot be patched.

@RealRaven2000
Copy link
Owner Author

For the issue with Thunderbird 102 I have raised issue #108

@RealRaven2000
Copy link
Owner Author

Latest version:

quickFilters-wx-5.5.2pre19.zip

To install, download zip file and drag into Thunderbird Add-ons Manager (do not unpack contents)

@RealRaven2000
Copy link
Owner Author

Fixed in 5.5.4 - released today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant