Support triggering assistant through: deleting mail / flagging mail as junk / archiving

[RealRaven2000]

Since v5.7.1. moving mail to Junk or Trash will categorically not invoke the active filter assistant. I believe older versions were more nuanced and would do different things depending on whether mail was moved / dragged or marked as junk / trash can clicked.

We will reintroduce the ability for these 2 special folders (Trash / Junk) to trigger the assistant, based on a user preference (UI to be built later).

[RealRaven2000]

Here is a test version - this one enables the assistant for junk and trash:

quickFilters-wx-5.7.2pre2.zip

however these can be disabled through the config settings

extensions.quickfilters.assistant.exclude.trash = true
extensions.quickfilters.assistant.exclude.junk = true

I am planning to build a UI around these special assistant options later. To install the version above, download the zip file and then drag the file into Thunderbird Agd-ons Manager (do not extract contents).

[PotatoCarl]

I used Pre9 with #143 and it works on delete but not for archiving. The two config settings cannot be found in the configuration here (neither in the thunderbird, nor in the debug settings directly accessible from the addon).

[RealRaven2000]

@PotatoCarl - here is a new preview version:

quickFilters-wx-5.7.2pre9.zip

I provided a very primitive interface for unsetting the flag (that by default will ignore archived messages). Open quickFilters Settings, and on the actions screen click on the button "Folders to ignore Assistant..."

This will display a filtered view of about:config. There you can change the setting:

extensions.quickfilters.assistant.exclude.archive=false

...then archiving messages will trigger the assistant (unless you already have a matching rule set up that could have archived the message automatically)

To install the prerelease version, download the zip file and drag it into Thunderbird Add-ons manager without extracting the contents.

[PotatoCarl]

Hi
The behaviour changed now:
If I delete a message (pressing DEL) now the filter assistant pops up. This was not the case in the previous version. When switching the exclude setting to exclude the Trash folder, the assistant is not triggered.
If I archiv a message, the filter assistant pops up, independend of the setting of the "exclude.archive" setting.
If I mark a message as junk, the assistant does NOT pop up (exclude setting for junk "true"). However, when I unmark it in the JUNK folder, it pops up.

Remark: My Archiv Settings form Thunderbird are set to "archive by years", so the folder structure is Archiv/

[RealRaven2000]

If I delete a message (pressing DEL) now the filter assistant pops up. This was not the case in the previous version. When switching the exclude setting to exclude the Trash folder, the assistant is not triggered.

This is right - and now by design. because the folder listener cannot distinguish between the cases of whether the user dragged an email into the trash, hit the DEL button or used some other method (such as using a quickMove operation by QuickFolders). It won't even know whether a filter deleted the email. So there is only triggering the assistant or not, which is reflected in the setting extensions.quickfilters.assistant.exclude.trash. This is the price I had to pay for removing the monkey patched functions that overwrote internal Thunderbird functions for the various possible user actions and then in turn could make a more qualified / nuanced decision whether the assistant would be triggered or not.

If I archiv a message, the filter assistant pops up, independend of the setting of the "exclude.archive" setting.

Strange I cannot confirm, using 5.7.2pre9, the assistant is not triggered if I archive (using the [A] key or dragging into the Archives folder) are you dragging it somewhere else (maybe a subfolder in Archives) or use yet another method of archiving?

For reference - this is what my archives folder looks like:

If I mark a message as junk, the assistant does NOT pop up (exclude setting for junk "true"). However, when I unmark it in the JUNK folder, it pops up.

By design so this on is working for you correctly.

[PotatoCarl]

So, I checked my "Archive Options" (account settings) and switched it to "one folder". But still, whenever I Archive a message, the filter pops up.
Besides, Thunderbird ignores the setting here and creates a folder with the year to which the message is stored.
I personally hate using the "A" key, as sometimes Thunderbird hangs and when I type blindly as usual it shoots a dozen mails into Archive.... So I reconfigured with TbKeys the Archive key to "INS".
An it is independend if using the key or the menu option "Archive".
However, I would propose to allow all built-in options that Archiving offers (I believe at some time the defaults was "one folder per month").

[RealRaven2000]

I tried setting a yearly archive in my test account, using this option

IF I archive a message it goes to Archives / 2022 and the assistant is still triggered (provided I do not exclude the archive setting). quickFilters uses the built in folder flags in order to determine whether a folder is an archive folder or not, so it should only be disabled if the flag is set and the exclusion is set to false. Otherwise the folder should just be treated like an ordinary folder and trigger the assistant. If you check the error console is there a message why it is omitted? There could already be a filter that was expected to archive the message automatically (in which case the assistant is not be triggered). Error console should tell us this especially if quickFilters debug mode is enabled. See quickFilters settings / advanced:

[PotatoCarl]

The following gest logged:

msgsMoveCopyCompleted()

Object { isMoved: true, aSrcMsgs: (1) […], targetFolder: XPCWrappedNative_NoHelper, aDestMsgs: (1) […] }
quickFilters.js:1388:15
moved 1 messages, now invoking filter assistant... quickFilters.js:1467:19
Diese Seite befindet sich im Kompatibilitätsmodus (Quirks). Das Seitenlayout kann beeinflusst werden. Verwenden Sie für den Standardmodus "". fetch>UID>.INBOX>355702
Layout-Darstellung wurde erzwungen, bevor die Seite vollständig geladen war. Falls Stylesheet noch nicht geladen sind, kann dies zu einem kurzzeitigen Darstellung des Inhalts ohne Formatierung führen. contentAreaClick.js:97:6
downloadable font: failed to start download (font-family: "MarriottFont" style:normal weight:400 stretch:100 src index:0): content blocked source: https://cache.marriott.com/aka-fonts/Sheraton/GT-Super-Display-Light.otf
quickFilters [logTime init]
selectTemplateFromListTimer()

[PotatoCarl]

FYI: I am doing everything on my IMAP server including Archiving. So I do not Archiv to local folders.

[RealRaven2000]

Object { isMoved: true, aSrcMsgs: (1) […], targetFolder: XPCWrappedNative_NoHelper, aDestMsgs: (1) […] }
quickFilters.js:1388:15
moved 1 messages, now invoking filter assistant... quickFilters.js:1467:19

It sounds like the assistant should actually be showing, at least with current versions of Thunderbird 91 / 102. Are you using a beta version?

[PotatoCarl]

It is showing, that is exactly my problem. I am archieving messages, so they are moved where they are supposed to go and I do not want the assistent to make a filter for me.

[RealRaven2000]

It is showing, that is exactly my problem. I am archieving messages, so they are moved where they are supposed to go and I do not want the assistent to make a filter for me.

If you do not want the assistant to pop up during archiving, please reset the setting to its default (true):

extensions.quickfilters.assistant.exclude.archive=true

in this context assistant.exclude means not to trigger the assistant for folders with the particular flag (archive)