Thunderbird crashes with quickFilters 5.7.1

[wsmwk]

@RealRaven2000

All crashes have quickFilters 5.7.1 installed. The earliest dating to Dec 26.
Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1808092

[RealRaven2000]

@wsmwk - Can we find out whether they had quickFilters assistant activated during the time of crash? Some people set the assistant to automatically start with Thunderbird (so they may not be aware that it is running):

The typical use case would be to activate it manually, then moved some emails manually and it will help with generating / auto-filling filters.

The major change in this version is that (following advice from @jobisoft) it removes monkey-patched code that was replacing the global MsgMoveMessage and MsgCopyMessage functions - it instead tries to use a folder listener to activate the assistant. At this stage we do not know what causes the mail to be moved, so in order to rule out filter activity itself (we are only interested in user interaction moving the mail) we check all filters that may have moved mail to the folder and if we find one and it matches the mail in all search terms, we do not open the assistant.

See quickFilters.MsgFolderListener.msgsMoveCopyCompleted()

link to code

This may take some time, but it follows the message being moved, I am not aware whether it would hold up filter execution to the point of crashing(?) - I don't really know how to read the crash report you linked.

I could avoid checking for matching filters if there was some global flag / status I could look at that could tell me that filtering is currently active. I couldn't really come up

[RealRaven2000]

PS: I would guess that they have filters that look into the body (content) of an email that are active at the time these filter are executed. I think searching message body contents can incur a great speed penalty. My assumption is that when the msgsMoveCopyCompleted event is triggered, the email has already been completely moved. Maybe there is a problem here with syncing / Imap?

[wsmwk]

On 1/20/23 5:43 AM, RealRaven2000 wrote: @wsmwk <https://github.com/wsmwk> - Can we find out whether /they had quickFilters assistant activated/ during the time of crash? Some people set the assistant to automatically start with Thunderbird (so they may not be aware that it is running):

Unfortunately there is no way to contact anyone.

[RealRaven2000]

• Can we find out whether /they had quickFilters assistant activated/ during the time of crash? Some people set the assistant to automatically start with Thunderbird (so they may not be aware that it is running):
  Unfortunately there is no way to contact anyone.

ok then I will probably have to deal with it when users report more detail to me directly.

[RealRaven2000]

New version, reinstated the monkey patch functions and removed the code in the folder listener:

quickFilters-wx-5.7.2pre65.zip

To install, download zip file above and drag into Thunderbird Add-ons Manager (without extracting contents).

[RealRaven2000]

Did a bunch of corrections and testing over at issue #145 - here is the latest version:

quickFilters-wx-5.8pre87.zip

To install, download zip file above and drag into Thunderbird Add-ons Manager (without extracting contents).

[RealRaven2000]

Removed more service wrappers (using MailServices). Latest version:

quickFilters-wx-5.8pre89.zip

To install, download zip file above and drag into Thunderbird Add-ons Manager (without extracting contents).

[RealRaven2000]

More refactoring of service wrappers after last Add-on Developers meeting yesterday night:

quickFilters-wx-5.8pre104.zip

To install, download zip file above and drag into Thunderbird Add-ons Manager (without extracting contents).

[RealRaven2000]

Should be fixed with 5.8 released today.

[wsmwk]

Should be fixed with 5.8 released today.

I agree. The crash is gone according to https://crash-stats.mozilla.org/signature/?signature=nsMsgBodyHandler%3A%3AnsMsgBodyHandler