Skip to content

Edit Custom filters shows all filters in Local folders (should only show filter templates) #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RealRaven2000 opened this issue Aug 6, 2023 · 2 comments
Assignees
Labels

Comments

@RealRaven2000
Copy link
Owner

When opening Custom Templates / Edit from the advanced tab, we expect to see a list of quickFilters custom templates only

image

instead all filters in the Local Folders are shown. In error console, we see the message:

Uncaught TypeError: fWin.quickFilters is undefined
    filterCustomTemplates chrome://quickfilters/content/qFilters-utils.js:1759
    filterCustomTemplates chrome://quickfilters/content/qFilters-utils.js:1779
qFilters-utils.js:1759:18
    filterCustomTemplates chrome://quickfilters/content/qFilters-utils.js:1759
    filterCustomTemplates chrome://quickfilters/content/qFilters-utils.js:1779

@RealRaven2000 RealRaven2000 self-assigned this Aug 6, 2023
@RealRaven2000
Copy link
Owner Author

This is possibly caused by the filter window not having been fully loaded (quickFilters injects itself via a chrom overlay), so it might be easily fixed by adding a delay of 250ms.

RealRaven2000 added a commit that referenced this issue Aug 6, 2023
RealRaven2000 added a commit that referenced this issue Aug 6, 2023
@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Aug 13, 2023

Fixed in 5.9.4 - Published 13/08/2023
also in 6.2 - Published 13/08/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant