Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Empty Conditions list due to removed recipients - filter cannot be edited #23

Closed
SKelem opened this issue Sep 24, 2020 · 4 comments
Assignees

Comments

@SKelem
Copy link

SKelem commented Sep 24, 2020

For some reason, the past few times I used quickFilters to create a filter, the condition was unintentionally set to Recipient.
This creates a filter with no conditions and no way to create a condition.
Screenshot from 2020-09-24 12-40-58

  1. There should be a way to add conditions here.
    After this window is dismissed, a message (that doesn't appear in a screen capture!) appears saying "quickFilters Email addresses were omitted from the conditions - quickFilt..."
  2. The message comes only after dismissing the useless popup. If it came before the popup, and before it moves the messages to the destination folder, then the action could be remedied. The only way to fix this is to turn off quickFilters, move the message back from the dest folder to the src folder, turn on quickFilters, remember to change the condition, and then things will be fine.
    Actually, it would be best if the message were issued before the first quickFilters popup is dismissed, or prevented the popup from being dismissed.

I hope this helps make quickFilters better!
Steve

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Sep 24, 2020

I will log this as enhancement. Hopefully I will be able to address it once we have quickFilters compatible with Thunderbird 78.

@RealRaven2000 RealRaven2000 changed the title Editing options unavailable when filter is set to Recipient Empty Conditions list due to removed recipients - provide a method to edit the filter Jan 22, 2021
@RealRaven2000
Copy link
Owner

As a quick workaround: should we return to the assistant where the filter template is selected if the conditions list will be empty? One could show a message: with the current filter template "by recipients", no meaningful filter conditions can be created, please select a different template.

@RealRaven2000 RealRaven2000 pinned this issue Jan 23, 2021
@RealRaven2000
Copy link
Owner

RealRaven2000 commented Mar 26, 2021

Here is my solution. Instead of creating a nonsensical filter that cannot be edited and wasting the users time, I display this message:
image

Trial version (Tb78):
quickFilters-wx-4.5pre7.zip

Trial version (Tb68):
quickFilters-wx-5.2pre30.zip

@RealRaven2000 RealRaven2000 changed the title Empty Conditions list due to removed recipients - provide a method to edit the filter Avoid Empty Conditions list due to removed recipients - filter cannot be edited Mar 26, 2021
@RealRaven2000
Copy link
Owner

Implemented in releases 4.5 + 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants