|
qF.Util.logDebugOptional("listeners", `MsgFolderListener.msgsMoveCopyCompleted()\n ${aSrcMsgs[0].folder.prettyName} ${targetFolder.prettyName} ${aDestMsgs && aDestMsgs.length ? aDestMsgs[0].folder.prettyName : "no destmsg!"}`); |
I might be looking at old docs but according to this, it's not an error/warning condition (warranting "!") if aDestMsgs is null.
Currently, if the imap move/copy happens strictly online (essentially, not user-initiated), then aDestMsgs will be null.
So perhaps rather than "no destmsg!", maybe empty string? 🥲 🙏
Reason: It looks like an error/warning message and draws unwarranted attention during debugging.
I don't think it's worthwhile here to check if aDestMsg is erroneously null or empty when using POP3 or otherwise when that condition wouldn't be valid. So this seems like a dirt-simple string change.
quickFilters/chrome/content/quickFilters.js
Line 1858 in 01811a2
I might be looking at old docs but according to this, it's not an error/warning condition (warranting "!") if aDestMsgs is null.
So perhaps rather than "no destmsg!", maybe empty string? 🥲 🙏
Reason: It looks like an error/warning message and draws unwarranted attention during debugging.
I don't think it's worthwhile here to check if aDestMsg is erroneously null or empty when using POP3 or otherwise when that condition wouldn't be valid. So this seems like a dirt-simple string change.