Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Next Steps" does not over-ride "Settings/Actions." #26

Closed
StuporDaveOsborne opened this issue Oct 24, 2020 · 9 comments
Closed

"Next Steps" does not over-ride "Settings/Actions." #26

StuporDaveOsborne opened this issue Oct 24, 2020 · 9 comments
Assignees
Labels
bug Tb78 Thunderbird 78 regression

Comments

@StuporDaveOsborne
Copy link

I mostly use my filters for tagging thousands of emails. Regarding the Settings -Actions for automatically "open editor " and "display filters list." These items appear in "settings" and similarly in "next steps" during filter creation. I have tested these in both directions, enabled or not in "settings." Either way, the "next steps" during filter creation will not over-ride the settings.
I don't know your intended behavior so I am posting this here.

@RealRaven2000
Copy link
Owner

the way it should work: these checkboxes are (should be) connected to the global setting so once you check /uncheck them they should remember this as default behavior. Do I understand you correctly that they

  • work during one assistant run
  • do not remember when you uncheck?

@StuporDaveOsborne
Copy link
Author

The check boxes do not seem to relate to the global settings at all.
I did further testing. I found the config settings and observed that 1: the default for both "editor" and "list""afterCreate" is enabled. However during creation the default "next steps" boxes are unchecked even though the global is enabled. Checking them makes no difference as the steps are already enabled, however UNchecking them also does nothing, the global settings do not change. I have tried this through restarts as well.
I have tested the checkboxes against globals both on & off, even through restarts. They don't over-ride the globals. Let me know if you need anything else.

@RealRaven2000
Copy link
Owner

The check boxes do not seem to relate to the global settings at all.
I did further testing. I found the config settings and observed that 1: the default for both "editor" and "list""afterCreate" is enabled. However during creation the default "next steps" boxes are unchecked even though the global is enabled. Checking them makes no difference as the steps are already enabled, however UNchecking them also does nothing, the global settings do not change. I have tried this through restarts as well.
I have tested the checkboxes against globals both on & off, even through restarts. They don't over-ride the globals. Let me know if you need anything else.

So what you're saying is - the checkboxes don't have any effect whatsoever? They are not stored globally, and they do not skip any screens if you uncheck?

@StuporDaveOsborne
Copy link
Author

StuporDaveOsborne commented Oct 25, 2020

That is correct. I did two tests, starting from a restart with "enabled" and checked, I unchecked during creation and still had both popups. Then I did another restart and created another filter (this time the checkboxes were already unchecked from the last filter) and still had both popups. The global config settings were still set to true, no change.

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Oct 25, 2020

That is correct. I did two tests, starting from a restart with "enabled" and checked, I unchecked during creation and still had both popups. Then I did another restart and created another filter (this time the checkboxes were already unchecked from the last filter) and still had both popups. The global config settings were still set to true, no change.

That's actually good news - sounds like the preferences aren't properly "wired up" with the configuration database - it shouldn't be too hard to reproduce / fix for the next beta!

To prioritize, I am going to pin this issue to the top so I won't miss it.

@RealRaven2000 RealRaven2000 self-assigned this Oct 25, 2020
@RealRaven2000 RealRaven2000 added bug Tb78 Thunderbird 78 regression labels Oct 25, 2020
@RealRaven2000 RealRaven2000 pinned this issue Oct 25, 2020
RealRaven2000 added a commit that referenced this issue Oct 28, 2020
@RealRaven2000
Copy link
Owner

RealRaven2000 commented Oct 28, 2020

Can you test this new beta version below:

https://github.com/RealRaven2000/quickFilters/releases/tag/5.0pre67

It should now show the settings correctly and save them after modification and obiviously also not ignore them anymore..

@StuporDaveOsborne
Copy link
Author

Settings are working correctly now.

@RealRaven2000
Copy link
Owner

Settings are working correctly now.

Good stuff. I am going to close the issue once we go live. John Bieling cam up with the initial pattern (a hack overwriting preference id with the name) and it works quite seamlessly giving back the automatic dialog to settings binding that we have grown so used to over the last decade.

@RealRaven2000 RealRaven2000 unpinned this issue Oct 28, 2020
@RealRaven2000
Copy link
Owner

Fixed in release 5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Tb78 Thunderbird 78 regression
Projects
None yet
Development

No branches or pull requests

2 participants