copy move menu broken with quickfilters

[farmatito]

Hi, I'm using quickfilters 5.0pre56 on Debian/Devuan 10 and I am experiencing an issue:
with quickfilters enabled at least the right click context menu actions
copy
move
move again to ...
are not working at all.
Drag and drop to the same folders work.
Delete is working instead.
Disabling quickfilters in the extensions page restores the correct behaviour.
Tell me if you need more or different infos.

Best regards,
farmatito

P.S.: same happens with thunderbird 78.4.0 on Windows 10

[RealRaven2000]

Ok, good catch! I am overwriting the global functions MsgMoveMessage() and MsgCopyMessage() in order to wrap them with additional functionality. For URI detection, I used an deprecated interface Ci.nsIRDFService which isn't available anymore - you would have seen an error in the error console stating this.

Please try this quick fix version:
quickFilters-wx-5.0pre69.zip

Note - since the previous version did not tidy up the aforementioned functions correctly you must restart after installing it for the first time!

[farmatito]

Hi,
tested quickFilters-wx-5.0pre69.zip. Seems to work in Linux Debian/Devuan but is still broken on Windows10.

Ciao,
farmatito

[RealRaven2000]

Hi,
tested quickFilters-wx-5.0pre69.zip. Seems to work in Linux Debian/Devuan but is still broken on Windows10.

Ciao,
farmatito

Make sure you restart. I tested in Windows 7, no issue there.

[farmatito]

Restart Windows or Thunderbird? I did restart Thunderbird.
After more testing on Win10 2004 64bit It does work sometimes (rarely)
but most of the times not. I could not detect any kind of pattern
as it seems rather erratic behaviour. There must still be something wrong.
Sometimes "copy/move again" works, you try again with another entry in the list and it doesn't.
Sometimes "copy/move" works, you retry and nothing.
Ciao,
farmatito

[RealRaven2000]

Restart Windows or Thunderbird? I did restart Thunderbird.
After more testing on Win10 2004 64bit It does work sometimes (rarely)
but most of the times not. I could not detect any kind of pattern
as it seems rather erratic behaviour. There must still be something wrong.

please check the JavaScript error console (Ctr+Shift+J) for those cases,. you can copy the error log with the right-click menu. Always reset before each test so we can have a full log.

[farmatito]

NAS 2020-10-31 15 02 System Events.zip
NAS 2020-10-31 16 02 System Events.zip

There is nothing in the logs. It happens erratically. The only thing I see is that when it starts to refuse to copy or move
a email message is that when you click on it in the list it is not showed in the box below the list. At this point tinkering
with the app (changing email account, changing folder, double clicking a message to open it in a separate tab) somehow
resets the program state and it start working again. The log still is empty.
Attached you will find some messages that more often than others trigger the bug. Hope this helps.

[farmatito]

Some steps to reproduce:
open thunderbird
create an empty folder in one account
drag and drop some messages into it
change to the folder
directly right click with the mouse one of the messages and choose move or copy
nothing is shown in the message box below the list
from this point "copy/move" and "move again" stop to work with all messages in the directory
now exit the folder and change to some other folder of an account
go back to test folder select a message with a left mouse click
message is shown in the message box below the list
mow "copy/move" "move again" works

Ciao,
Tito

P.S.: the same steps are also reproducible in linux

[RealRaven2000]

NAS 2020-10-31 15 02 System Events.zip
NAS 2020-10-31 16 02 System Events.zip

These do not look like Thunderbird logs. You need to open the Thunderbird menu - Tools / Developer Tools / Error Console.

For additional messages during message moving / copying with quickFilters enabled, you can do 2 additional things

1. enable quickFilters debug mode from the bottom right of the Advanced tab:
   
2. you can enable additional detail during debug mode by right-clicking the debug checkbox, then setting

extensions.quickfilters.debug.msgMove = true

This will give additional detail. By the way instead of pasting the log into an email and then archiving that, why not use a plain text file?

Typical expected output (I know it's a lot):

quickFilters {MSGMOVE} 15:25:47.580  [19708 ms]   
 quickFilters.executeMoveMessage == quickFilters.MsgMove_Wrapper :false
quickFilters {MSGMOVE} 15:25:47.580  [0 ms]   
Executing wrapped MsgMoveMessage
quickFilters {MSGMOVE} 15:25:47.580  [0 ms]   
 setTimeout(..) for final move / copy call
quickFilters {MSGMOVE} 15:25:47.601  [21 ms]   
Executing original MoveMessage [[
quickFilters {MSGMOVE} 15:25:47.602  [1 ms]   
After original Move/CopyMessage.]]
quickFilters {MSGMOVE} 15:25:47.605  [3 ms]   
OnItemAdded() [xpconnect wrapped nsIMsgDBHdr]
quickFilters {MSGMOVE} 15:25:47.612  [7 ms]   
DeleteOrMoveMsgCompleted(Inbox)
Assistant is off
quickFilters {MSGMOVE} 15:25:47.612  [0 ms]   
Source folder (Inbox) is local inbox = false
quickFilters {MSGMOVE} 15:25:47.612  [0 ms]   
List of LocalMoved = 0 items.
... possibly there will be more DeleteOrMoveMsgCompleted events below...

[farmatito]

These do not look like Thunderbird logs. You need to open the Thunderbird menu - Tools / Developer Tools / Error Console.

They were just some email messages that at first I thought were triggering the issue, but they are not.
You could reproduce the issue with the steps defined above.
If you could try them with quickfilters debug on it could eventually show that this is rather a thunderbird 78.4.* bug
or change in behaviour (that I never noticed before).
In the JavaScript error console there was nothing at all.

Ciao,
Tito

[StuporDaveOsborne]

Some steps to reproduce:
open thunderbird
create an empty folder in one account
drag and drop some messages into it
change to the folder
directly right click with the mouse one of the messages and choose move or copy
nothing is shown in the message box below the list
from this point "copy/move" and "move again" stop to work with all messages in the directory
now exit the folder and change to some other folder of an account
go back to test folder select a message with a left mouse click
message is shown in the message box below the list
mow "copy/move" "move again" works

Ciao,
Tito

P.S.: the same steps are also reproducible in linux

I was unable to reproduce this on 5Pre69, Win7x64, TB 78.4.0 x32bit. I have numerous accounts and was able to direct mails to folders under both "copy to" and "move to."
Please note I did not use QF to create any filters during this test, I only tested the ability to copy/move messages while QF enabled.